From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [RFC PATCH] target/m68k: Use i128 for 128-bit load/store in m68k_copy_line()
Date: Tue, 17 Oct 2023 14:27:02 +0200 [thread overview]
Message-ID: <20231017122702.39311-1-philmd@linaro.org> (raw)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Based-on: <20231013175109.124308-1-richard.henderson@linaro.org>
tcg: Add tcg_gen_{ld,st}_i128
RFC because unsure and untested...
---
target/m68k/translate.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 4d0110de95..1e3d155bd9 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -4293,23 +4293,17 @@ DISAS_INSN(chk2)
static void m68k_copy_line(TCGv dst, TCGv src, int index)
{
+ MemOp mop = MO_128 | MO_TE;
+ TCGv_i128 t = tcg_temp_new_i128();
TCGv addr;
- TCGv_i64 t0, t1;
addr = tcg_temp_new();
- t0 = tcg_temp_new_i64();
- t1 = tcg_temp_new_i64();
-
tcg_gen_andi_i32(addr, src, ~15);
- tcg_gen_qemu_ld_i64(t0, addr, index, MO_TEUQ);
- tcg_gen_addi_i32(addr, addr, 8);
- tcg_gen_qemu_ld_i64(t1, addr, index, MO_TEUQ);
+ tcg_gen_qemu_ld_i128(t, addr, index, mop);
tcg_gen_andi_i32(addr, dst, ~15);
- tcg_gen_qemu_st_i64(t0, addr, index, MO_TEUQ);
- tcg_gen_addi_i32(addr, addr, 8);
- tcg_gen_qemu_st_i64(t1, addr, index, MO_TEUQ);
+ tcg_gen_st_i128(t, addr, index);
}
DISAS_INSN(move16_reg)
--
2.41.0
next reply other threads:[~2023-10-17 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 12:27 Philippe Mathieu-Daudé [this message]
2023-10-17 13:44 ` [RFC PATCH] target/m68k: Use i128 for 128-bit load/store in m68k_copy_line() Richard Henderson
2023-10-17 13:52 ` Richard Henderson
2023-10-30 13:51 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017122702.39311-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).