qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
	"Zhenzhong Duan" <zhenzhong.duan@intel.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 16/22] vfio/pci: Fix a potential memory leak in vfio_listener_region_add
Date: Wed, 18 Oct 2023 11:45:25 +0200	[thread overview]
Message-ID: <20231018094531.733211-17-clg@redhat.com> (raw)
In-Reply-To: <20231018094531.733211-1-clg@redhat.com>

From: Zhenzhong Duan <zhenzhong.duan@intel.com>

When there is an failure in vfio_listener_region_add() and the section
belongs to a ram device, there is an inaccurate error report which should
never be related to vfio_dma_map failure. The memory holding err is also
incrementally leaked in each failure.

Fix it by reporting the real error and free it.

Fixes: 567b5b309ab ("vfio/pci: Relax DMA map errors for MMIO regions")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/vfio/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 9e61de03ee0ee611264ab9943d8e5abc1320c766..5ff5acf1d878a148b7920ce32517be878129940e 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -763,7 +763,7 @@ static void vfio_listener_region_add(MemoryListener *listener,
 
 fail:
     if (memory_region_is_ram_device(section->mr)) {
-        error_report("failed to vfio_dma_map. pci p2p may not work");
+        error_reportf_err(err, "PCI p2p may not work: ");
         return;
     }
     /*
-- 
2.41.0



  parent reply	other threads:[~2023-10-18  9:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  9:45 [PULL 00/22] vfio queue Cédric Le Goater
2023-10-18  9:45 ` [PULL 01/22] scripts/update-linux-headers: Add iommufd.h Cédric Le Goater
2023-10-18  9:45 ` [PULL 02/22] linux-headers: " Cédric Le Goater
2023-10-18  9:45 ` [PULL 03/22] vfio/common: Move IOMMU agnostic helpers to a separate file Cédric Le Goater
2023-10-18  9:45 ` [PULL 04/22] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any Cédric Le Goater
2023-10-18  9:45 ` [PULL 05/22] vfio/common: Introduce vfio_container_add|del_section_window() Cédric Le Goater
2023-10-18  9:45 ` [PULL 06/22] vfio/common: Extract out vfio_kvm_device_[add/del]_fd Cédric Le Goater
2023-10-18  9:45 ` [PULL 07/22] vfio/pci: Introduce vfio_[attach/detach]_device Cédric Le Goater
2023-10-18  9:45 ` [PULL 08/22] vfio/platform: Use vfio_[attach/detach]_device Cédric Le Goater
2023-10-18  9:45 ` [PULL 09/22] vfio/ap: " Cédric Le Goater
2023-10-18  9:45 ` [PULL 10/22] vfio/ccw: " Cédric Le Goater
2023-10-18  9:45 ` [PULL 11/22] vfio/common: Move VFIO reset handler registration to a group agnostic function Cédric Le Goater
2023-10-18  9:45 ` [PULL 12/22] vfio/common: Introduce a per container device list Cédric Le Goater
2023-10-18  9:45 ` [PULL 13/22] vfio/common: Store the parent container in VFIODevice Cédric Le Goater
2023-10-18  9:45 ` [PULL 14/22] vfio/common: Introduce a global VFIODevice list Cédric Le Goater
2023-10-18  9:45 ` [PULL 15/22] vfio/common: Move legacy VFIO backend code into separate container.c Cédric Le Goater
2023-10-18  9:45 ` Cédric Le Goater [this message]
2023-10-18  9:45 ` [PULL 17/22] vfio/ap: Remove pointless apdev variable Cédric Le Goater
2023-10-18  9:45 ` [PULL 18/22] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW Cédric Le Goater
2023-10-18  9:45 ` [PULL 19/22] vfio/pci: Remove vfio_detach_device from vfio_realize error path Cédric Le Goater
2023-10-18  9:45 ` [PULL 20/22] ramfb: add migration support Cédric Le Goater
2023-10-18  9:45 ` [PULL 21/22] ramfb-standalone: " Cédric Le Goater
2023-10-18  9:45 ` [PULL 22/22] hw/vfio: add ramfb " Cédric Le Goater
2023-10-18 22:32 ` [PULL 00/22] vfio queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018094531.733211-17-clg@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).