qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com,
	anisinha@redhat.com, marcel.apfelbaum@gmail.com
Subject: Re: [PATCH 0/3] hw/i386: Add MTD controller on ICH9
Date: Wed, 18 Oct 2023 09:47:40 -0400	[thread overview]
Message-ID: <20231018094701-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20231018115231.3547102-1-patrick.rudolph@9elements.com>

On Wed, Oct 18, 2023 at 01:52:28PM +0200, Patrick Rudolph wrote:
> This series implements a feature complete MTD SPI flash controller
> as found on real ICH9, adds cache coherent BIOS MMAPing and implements
> a few SMM bits to allow x86 firmware build for real ICH9 to operate on
> the flash controller to store (UEFI) variables or do firmware updates.
> 
> Patrick Rudolph (3):
>   hw/isa/ich9: Add SPI controller
>   hw/isa/lpc_ich9: Implement SMI_STS for APMC
>   hw/i386/pc_sysfw: Do not create BIOS region if MTD is present


Given all this is guest-visible, one thing we need for sure is
a flag disabling this new stuff, and tied to existing machine types.

>  hw/acpi/ich9.c                    |   5 +
>  hw/acpi/ich9_tco.c                |   5 +
>  hw/i386/pc_sysfw.c                |   6 +
>  hw/isa/Kconfig                    |   2 +
>  hw/isa/lpc_ich9.c                 |   4 +
>  hw/isa/meson.build                |   2 +-
>  hw/isa/spi_ich9.c                 | 448 ++++++++++++++++++++++++++++++
>  include/hw/southbridge/ich9.h     |   6 +
>  include/hw/southbridge/ich9_spi.h |  80 ++++++
>  9 files changed, 557 insertions(+), 1 deletion(-)
>  create mode 100644 hw/isa/spi_ich9.c
>  create mode 100644 include/hw/southbridge/ich9_spi.h
> 
> -- 
> 2.41.0



      parent reply	other threads:[~2023-10-18 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 11:52 [PATCH 0/3] hw/i386: Add MTD controller on ICH9 Patrick Rudolph
2023-10-18 11:52 ` [PATCH 1/3] hw/isa/ich9: Add SPI controller Patrick Rudolph
2023-10-18 11:52 ` [PATCH 2/3] hw/isa/lpc_ich9: Implement SMI_STS for APMC Patrick Rudolph
2023-10-18 11:52 ` [PATCH 3/3] hw/i386/pc_sysfw: Do not create BIOS region if MTD is present Patrick Rudolph
2023-10-18 13:47 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018094701-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).