Re: [PATCH v2] intel-iommu: Report interrupt remapping faults, fix return value

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Oct 17, 2023 at 10:29:39PM +0100, David Woodhouse wrote:
> On Tue, 2023-10-17 at 17:28 -0400, Michael S. Tsirkin wrote:
> > On Tue, Oct 17, 2023 at 10:19:55PM +0100, David Woodhouse wrote:
> > > On Wed, 2023-08-23 at 11:37 -0400, Peter Xu wrote:
> > > > On Wed, Aug 23, 2023 at 01:23:25PM +0100, David Woodhouse wrote:
> > > > > From: David Woodhouse <dwmw@amazon.co.uk>
> > > > > 
> > > > > A generic X86IOMMUClass->int_remap function should not return VT-d
> > > > > specific values; fix it to return 0 if the interrupt was successfully
> > > > > translated or -EINVAL if not.
> > > > > 
> > > > > The VTD_FR_IR_xxx values are supposed to be used to actually raise
> > > > > faults through the fault reporting mechanism, so do that instead for
> > > > > the case where the IRQ is actually being injected.
> > > > > 
> > > > > There is more work to be done here, as pretranslations for the KVM IRQ
> > > > > routing table can't fault; an untranslatable IRQ should be handled in
> > > > > userspace and the fault raised only when the IRQ actually happens (if
> > > > > indeed the IRTE is still not valid at that time). But we can work on
> > > > > that later; we can at least raise faults for the direct case.
> > > > > 
> > > > > Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> > > > 
> > > > Acked-by: Peter Xu <peterx@redhat.com>
> > > 
> > > Thanks.
> > > 
> > > What do I do with this next? It's still lurking in my working tree.
> > > 
> > > 
> > 
> > Not sure how I lost it. Sorry. Will pick up.
> 
> I think I just posted it at the wrong time of the release cycle.
> Thanks.
> 



I fixed some tab-indent issues and picked it up.