From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Peter Xu" <peterx@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sergio Lopez" <slp@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Song Gao" <gaosong@loongson.cn>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 04/12] hw/misc/allwinner-dramc: Do not use SysBus API to map local MMIO region
Date: Wed, 18 Oct 2023 16:11:42 +0200 [thread overview]
Message-ID: <20231018141151.87466-5-philmd@linaro.org> (raw)
In-Reply-To: <20231018141151.87466-1-philmd@linaro.org>
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/misc/allwinner-r40-dramc.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/misc/allwinner-r40-dramc.c b/hw/misc/allwinner-r40-dramc.c
index 2cc0254a55..3d81ddb2e1 100644
--- a/hw/misc/allwinner-r40-dramc.c
+++ b/hw/misc/allwinner-r40-dramc.c
@@ -414,7 +414,6 @@ static void allwinner_r40_dramc_reset(DeviceState *dev)
static void allwinner_r40_dramc_realize(DeviceState *dev, Error **errp)
{
AwR40DramCtlState *s = AW_R40_DRAMC(dev);
- SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
if (!get_match_ddr(s->ram_size)) {
error_report("%s: ram-size %u MiB is not supported",
@@ -422,23 +421,23 @@ static void allwinner_r40_dramc_realize(DeviceState *dev, Error **errp)
exit(1);
}
- /* R40 support max 2G memory but we only support up to 1G now. index 3 */
+ /* R40 support max 2G memory but we only support up to 1G now. */
memory_region_init_io(&s->detect_cells, OBJECT(s),
&allwinner_r40_detect_ops, s,
"DRAMCELLS", 1 * GiB);
- sysbus_init_mmio(sbd, &s->detect_cells);
- sysbus_mmio_map_overlap(sbd, 3, s->ram_addr, 10);
+ memory_region_add_subregion_overlap(get_system_memory(), s->ram_addr,
+ &s->detect_cells, 10);
memory_region_set_enabled(&s->detect_cells, false);
/*
* We only support DRAM size up to 1G now, so prepare a high memory page
- * after 1G for dualrank detect. index = 4
+ * after 1G for dualrank detect.
*/
memory_region_init_io(&s->dram_high, OBJECT(s),
&allwinner_r40_dualrank_detect_ops, s,
"DRAMHIGH", KiB);
- sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->dram_high);
- sysbus_mmio_map(SYS_BUS_DEVICE(s), 4, s->ram_addr + GiB);
+ memory_region_add_subregion(get_system_memory(), s->ram_addr + GiB,
+ &s->dram_high);
}
static void allwinner_r40_dramc_init(Object *obj)
--
2.41.0
next prev parent reply other threads:[~2023-10-18 14:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:11 [PATCH 00/12] hw: Strengthen SysBus & QBus API Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 01/12] hw/i386/amd_iommu: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 02/12] hw/i386/intel_iommu: " Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 03/12] hw/misc/allwinner-dramc: Move sysbus_mmio_map call from init -> realize Philippe Mathieu-Daudé
2023-10-18 14:11 ` Philippe Mathieu-Daudé [this message]
2023-10-18 14:11 ` [PATCH 05/12] hw/pci-host/bonito: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-18 16:05 ` Thomas Huth
2023-10-18 18:23 ` Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 06/12] hw/acpi: Realize ACPI_GED sysbus device before accessing it Philippe Mathieu-Daudé
2023-10-18 16:00 ` Thomas Huth
2023-10-18 14:11 ` [PATCH 07/12] hw/arm/virt: Realize ARM_GICV2M " Philippe Mathieu-Daudé
2023-10-18 15:58 ` Thomas Huth
2023-10-18 14:11 ` [PATCH 08/12] hw/isa: Realize ISA BUS " Philippe Mathieu-Daudé
2023-10-18 15:57 ` Thomas Huth
2023-10-18 18:26 ` Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 09/12] hw/s390x/css-bridge: Realize " Philippe Mathieu-Daudé
2023-10-18 15:06 ` Thomas Huth
2023-10-18 18:27 ` Philippe Mathieu-Daudé
2023-10-18 14:11 ` [PATCH 10/12] hw/qdev: Ensure parent device is not realized before adding bus Philippe Mathieu-Daudé
2023-10-18 16:08 ` Thomas Huth
2023-10-18 14:11 ` [PATCH 11/12] hw/sysbus: Ensure device is not realized before adding MMIO region Philippe Mathieu-Daudé
2023-10-18 16:10 ` Thomas Huth
2023-10-18 14:11 ` [PATCH 12/12] hw/sysbus: Ensure device is realized before mapping it Philippe Mathieu-Daudé
2023-10-18 16:13 ` Thomas Huth
2023-10-18 18:24 ` Philippe Mathieu-Daudé
2023-10-18 16:11 ` [PATCH 00/12] hw: Strengthen SysBus & QBus API Michael S. Tsirkin
2023-10-18 16:24 ` Thomas Huth
2023-10-18 18:25 ` Philippe Mathieu-Daudé
2023-10-18 18:32 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018141151.87466-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=b.galvani@gmail.com \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=gaosong@loongson.cn \
--cc=iii@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).