From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 14/17] kvm: i386: require KVM_CAP_MCE
Date: Wed, 18 Oct 2023 18:37:25 +0200 [thread overview]
Message-ID: <20231018163728.363879-15-pbonzini@redhat.com> (raw)
In-Reply-To: <20231018163728.363879-1-pbonzini@redhat.com>
This was introduced in KVM in Linux 2.6.34, we can require it unconditionally.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
accel/kvm/kvm-all.c | 5 -----
target/i386/kvm/kvm.c | 14 ++++----------
2 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 608da41465d..41d388acff2 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3131,11 +3131,6 @@ bool kvm_has_sync_mmu(void)
return kvm_state->sync_mmu;
}
-int kvm_has_robust_singlestep(void)
-{
- return kvm_state->robust_singlestep;
-}
-
int kvm_max_nested_state_length(void)
{
return kvm_state->max_nested_state_len;
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 5db3fd0f4c4..6df8d56c87e 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -97,6 +97,7 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
KVM_CAP_INFO(XSAVE),
KVM_CAP_INFO(VCPU_EVENTS),
KVM_CAP_INFO(X86_ROBUST_SINGLESTEP),
+ KVM_CAP_INFO(MCE),
KVM_CAP_LAST_INFO
};
@@ -582,14 +583,8 @@ uint64_t kvm_arch_get_supported_msr_feature(KVMState *s, uint32_t index)
static int kvm_get_mce_cap_supported(KVMState *s, uint64_t *mce_cap,
int *max_banks)
{
- int r;
-
- r = kvm_check_extension(s, KVM_CAP_MCE);
- if (r > 0) {
- *max_banks = r;
- return kvm_ioctl(s, KVM_X86_GET_MCE_CAP_SUPPORTED, mce_cap);
- }
- return -ENOSYS;
+ *max_banks = kvm_check_extension(s, KVM_CAP_MCE);
+ return kvm_ioctl(s, KVM_X86_GET_MCE_CAP_SUPPORTED, mce_cap);
}
static void kvm_mce_inject(X86CPU *cpu, hwaddr paddr, int code)
@@ -2116,8 +2111,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
if (((env->cpuid_version >> 8)&0xF) >= 6
&& (env->features[FEAT_1_EDX] & (CPUID_MCE | CPUID_MCA)) ==
- (CPUID_MCE | CPUID_MCA)
- && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
+ (CPUID_MCE | CPUID_MCA)) {
uint64_t mcg_cap, unsupported_caps;
int banks;
int ret;
--
2.41.0
next prev parent reply other threads:[~2023-10-18 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 16:37 [PATCH 00/17] kvm: drop support for really old kernels Paolo Bonzini
2023-10-18 16:37 ` [PATCH 01/17] kvm: remove unnecessary stub Paolo Bonzini
2023-10-20 12:19 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 02/17] kvm: require KVM_CAP_INTERNAL_ERROR_DATA Paolo Bonzini
2023-10-20 12:23 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 03/17] kvm: require KVM_CAP_SIGNAL_MSI Paolo Bonzini
2023-10-18 16:37 ` [PATCH 04/17] kvm: require KVM_CAP_IRQFD for kernel irqchip Paolo Bonzini
2023-10-20 12:24 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 05/17] kvm: drop reference to KVM_CAP_PCI_2_3 Paolo Bonzini
2023-10-18 16:37 ` [PATCH 06/17] kvm: assume that many ioeventfds can be created Paolo Bonzini
2023-10-18 16:37 ` [PATCH 07/17] kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH Paolo Bonzini
2023-10-18 16:37 ` [PATCH 08/17] kvm: unify listeners for PIO address space Paolo Bonzini
2023-10-20 12:31 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 09/17] kvm: arm: require KVM_CAP_SET_VCPU_EVENTS Paolo Bonzini
2023-10-18 16:37 ` [PATCH 10/17] kvm: i386: move KVM_CAP_IRQ_ROUTING detection to kvm_arch_required_capabilities Paolo Bonzini
2023-10-18 16:37 ` [PATCH 11/17] kvm: i386: require KVM_CAP_DEBUGREGS Paolo Bonzini
2023-10-18 16:37 ` [PATCH 12/17] kvm: i386: require KVM_CAP_XSAVE Paolo Bonzini
2023-10-18 16:37 ` [PATCH 13/17] kvm: i386: require KVM_CAP_SET_VCPU_EVENTS and KVM_CAP_X86_ROBUST_SINGLESTEP Paolo Bonzini
2023-10-18 16:37 ` Paolo Bonzini [this message]
2023-10-18 16:37 ` [PATCH 15/17] kvm: i386: require KVM_CAP_ADJUST_CLOCK Paolo Bonzini
2023-10-18 16:37 ` [PATCH 16/17] kvm: i386: require KVM_CAP_SET_IDENTITY_MAP_ADDR Paolo Bonzini
2023-10-18 16:37 ` [PATCH 17/17] kvm: i8254: require KVM_CAP_PIT2 and KVM_CAP_PIT_STATE2 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018163728.363879-15-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).