From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 16/17] kvm: i386: require KVM_CAP_SET_IDENTITY_MAP_ADDR
Date: Wed, 18 Oct 2023 18:37:27 +0200 [thread overview]
Message-ID: <20231018163728.363879-17-pbonzini@redhat.com> (raw)
In-Reply-To: <20231018163728.363879-1-pbonzini@redhat.com>
This was introduced in KVM in Linux 2.6.32, we can require it unconditionally.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/kvm/kvm.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index df131fcc8b1..a3d52cb538f 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -99,6 +99,7 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
KVM_CAP_INFO(X86_ROBUST_SINGLESTEP),
KVM_CAP_INFO(MCE),
KVM_CAP_INFO(ADJUST_CLOCK),
+ KVM_CAP_INFO(SET_IDENTITY_MAP_ADDR),
KVM_CAP_LAST_INFO
};
@@ -2600,20 +2601,13 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
* In order to use vm86 mode, an EPT identity map and a TSS are needed.
* Since these must be part of guest physical memory, we need to allocate
* them, both by setting their start addresses in the kernel and by
- * creating a corresponding e820 entry. We need 4 pages before the BIOS.
- *
- * Older KVM versions may not support setting the identity map base. In
- * that case we need to stick with the default, i.e. a 256K maximum BIOS
- * size.
+ * creating a corresponding e820 entry. We need 4 pages before the BIOS,
+ * so this value allows up to 16M BIOSes.
*/
- if (kvm_check_extension(s, KVM_CAP_SET_IDENTITY_MAP_ADDR)) {
- /* Allows up to 16M BIOSes. */
- identity_base = 0xfeffc000;
-
- ret = kvm_vm_ioctl(s, KVM_SET_IDENTITY_MAP_ADDR, &identity_base);
- if (ret < 0) {
- return ret;
- }
+ identity_base = 0xfeffc000;
+ ret = kvm_vm_ioctl(s, KVM_SET_IDENTITY_MAP_ADDR, &identity_base);
+ if (ret < 0) {
+ return ret;
}
/* Set TSS base one page after EPT identity map. */
--
2.41.0
next prev parent reply other threads:[~2023-10-18 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 16:37 [PATCH 00/17] kvm: drop support for really old kernels Paolo Bonzini
2023-10-18 16:37 ` [PATCH 01/17] kvm: remove unnecessary stub Paolo Bonzini
2023-10-20 12:19 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 02/17] kvm: require KVM_CAP_INTERNAL_ERROR_DATA Paolo Bonzini
2023-10-20 12:23 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 03/17] kvm: require KVM_CAP_SIGNAL_MSI Paolo Bonzini
2023-10-18 16:37 ` [PATCH 04/17] kvm: require KVM_CAP_IRQFD for kernel irqchip Paolo Bonzini
2023-10-20 12:24 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 05/17] kvm: drop reference to KVM_CAP_PCI_2_3 Paolo Bonzini
2023-10-18 16:37 ` [PATCH 06/17] kvm: assume that many ioeventfds can be created Paolo Bonzini
2023-10-18 16:37 ` [PATCH 07/17] kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH Paolo Bonzini
2023-10-18 16:37 ` [PATCH 08/17] kvm: unify listeners for PIO address space Paolo Bonzini
2023-10-20 12:31 ` Manos Pitsidianakis
2023-10-18 16:37 ` [PATCH 09/17] kvm: arm: require KVM_CAP_SET_VCPU_EVENTS Paolo Bonzini
2023-10-18 16:37 ` [PATCH 10/17] kvm: i386: move KVM_CAP_IRQ_ROUTING detection to kvm_arch_required_capabilities Paolo Bonzini
2023-10-18 16:37 ` [PATCH 11/17] kvm: i386: require KVM_CAP_DEBUGREGS Paolo Bonzini
2023-10-18 16:37 ` [PATCH 12/17] kvm: i386: require KVM_CAP_XSAVE Paolo Bonzini
2023-10-18 16:37 ` [PATCH 13/17] kvm: i386: require KVM_CAP_SET_VCPU_EVENTS and KVM_CAP_X86_ROBUST_SINGLESTEP Paolo Bonzini
2023-10-18 16:37 ` [PATCH 14/17] kvm: i386: require KVM_CAP_MCE Paolo Bonzini
2023-10-18 16:37 ` [PATCH 15/17] kvm: i386: require KVM_CAP_ADJUST_CLOCK Paolo Bonzini
2023-10-18 16:37 ` Paolo Bonzini [this message]
2023-10-18 16:37 ` [PATCH 17/17] kvm: i8254: require KVM_CAP_PIT2 and KVM_CAP_PIT_STATE2 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018163728.363879-17-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).