From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: deller@gmx.de
Subject: [PATCH 01/61] include/hw/elf: Remove truncating signed casts
Date: Wed, 18 Oct 2023 14:50:35 -0700 [thread overview]
Message-ID: <20231018215135.1561375-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20231018215135.1561375-1-richard.henderson@linaro.org>
There's nothing about elf that specifically requires signed vs unsigned.
This is very much a target-specific preference.
In the meantime, casting low and high from uint64_t back to Elf_SWord
to uint64_t discards high bits that might have been set by translate_fn.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/hw/elf_ops.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
index dffb0e73d2..0a5c258fe6 100644
--- a/include/hw/elf_ops.h
+++ b/include/hw/elf_ops.h
@@ -385,10 +385,11 @@ static ssize_t glue(load_elf, SZ)(const char *name, int fd,
}
if (pflags) {
- *pflags = (elf_word)ehdr.e_flags;
+ *pflags = ehdr.e_flags;
+ }
+ if (pentry) {
+ *pentry = ehdr.e_entry;
}
- if (pentry)
- *pentry = (uint64_t)(elf_sword)ehdr.e_entry;
glue(load_symbols, SZ)(&ehdr, fd, must_swab, clear_lsb, sym_cb);
@@ -610,10 +611,12 @@ static ssize_t glue(load_elf, SZ)(const char *name, int fd,
}
}
- if (lowaddr)
- *lowaddr = (uint64_t)(elf_sword)low;
- if (highaddr)
- *highaddr = (uint64_t)(elf_sword)high;
+ if (lowaddr) {
+ *lowaddr = low;
+ }
+ if (highaddr) {
+ *highaddr = high;
+ }
ret = total_size;
fail:
if (mapped_file) {
--
2.34.1
next prev parent reply other threads:[~2023-10-18 22:00 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 21:50 [PATCH 00/61] target/hppa: Implement hppa64-cpu Richard Henderson
2023-10-18 21:50 ` Richard Henderson [this message]
2023-10-18 21:50 ` [PATCH 02/61] target/hppa: Remove get_temp Richard Henderson
2023-10-19 9:41 ` Philippe Mathieu-Daudé
2023-10-18 21:50 ` [PATCH 03/61] target/hppa: Remove get_temp_tl Richard Henderson
2023-10-19 9:42 ` Philippe Mathieu-Daudé
2023-10-18 21:50 ` [PATCH 04/61] target/hppa: Remove load_const Richard Henderson
2023-10-18 21:50 ` [PATCH 05/61] target/hppa: Fix hppa64 case in machine.c Richard Henderson
2023-10-18 21:50 ` [PATCH 06/61] target/hppa: Fix load in do_load_32 Richard Henderson
2023-10-19 9:42 ` Philippe Mathieu-Daudé
2023-10-18 21:50 ` [PATCH 07/61] target/hppa: Truncate rotate count in trans_shrpw_sar Richard Henderson
2023-10-18 21:50 ` [PATCH 08/61] target/hppa: Fix trans_ds for hppa64 Richard Henderson
2023-10-18 21:50 ` [PATCH 09/61] target/hppa: Fix do_add, do_sub " Richard Henderson
2023-10-18 21:50 ` [PATCH 10/61] target/hppa: Fix bb_sar " Richard Henderson
2023-10-18 21:50 ` [PATCH 11/61] target/hppa: Fix extrw and depw with sar " Richard Henderson
2023-10-18 21:50 ` [PATCH 12/61] target/hppa: Introduce TYPE_HPPA64_CPU Richard Henderson
2023-10-19 9:44 ` Philippe Mathieu-Daudé
2023-10-18 21:50 ` [PATCH 13/61] target/hppa: Make HPPA_BTLB_ENTRIES variable Richard Henderson
2023-10-18 21:50 ` [PATCH 14/61] target/hppa: Implement cpu_list Richard Henderson
2023-10-18 21:50 ` [PATCH 15/61] target/hppa: Implement hppa_cpu_class_by_name Richard Henderson
2023-10-18 21:50 ` [PATCH 16/61] target/hppa: Update cpu_hppa_get/put_psw for hppa64 Richard Henderson
2023-10-18 21:50 ` [PATCH 17/61] target/hppa: Handle absolute addresses for pa2.0 Richard Henderson
2023-10-18 21:50 ` [PATCH 18/61] target/hppa: Adjust hppa_cpu_dump_state for hppa64 Richard Henderson
2023-10-18 21:50 ` [PATCH 19/61] hw/hppa: Translate phys addresses for the cpu Richard Henderson
2023-10-18 21:50 ` [PATCH 20/61] target/hppa: Fix hppa64 addressing Richard Henderson
2023-10-18 21:50 ` [PATCH 21/61] target/hppa: sar register allows only 5 bits on 32-bit CPU Richard Henderson
2023-10-18 21:50 ` [PATCH 22/61] target/hppa: Pass d to do_cond Richard Henderson
2023-10-18 21:50 ` [PATCH 23/61] target/hppa: Pass d to do_sub_cond Richard Henderson
2023-10-18 21:50 ` [PATCH 24/61] target/hppa: Pass d to do_log_cond Richard Henderson
2023-10-18 21:50 ` [PATCH 25/61] target/hppa: Pass d to do_sed_cond Richard Henderson
2023-10-18 21:51 ` [PATCH 26/61] target/hppa: Pass d to do_unit_cond Richard Henderson
2023-10-18 21:51 ` [PATCH 27/61] linux-user/hppa: Fixes for TARGET_ABI32 Richard Henderson
2023-10-19 9:49 ` Philippe Mathieu-Daudé
2023-10-18 21:51 ` [PATCH 28/61] target/hppa: Drop attempted gdbstub support for hppa64 Richard Henderson
2023-10-18 21:51 ` [PATCH 29/61] target/hppa: Remove TARGET_HPPA64 Richard Henderson
2023-10-18 21:51 ` [PATCH 30/61] target/hppa: Decode d for logical instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 31/61] target/hppa: Decode d for unit instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 32/61] target/hppa: Decode d for cmpclr instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 33/61] target/hppa: Decode d for add instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 34/61] target/hppa: Decode d for sub instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 35/61] target/hppa: Decode d for bb instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 36/61] target/hppa: Decode d for cmpb instructions Richard Henderson
2023-10-18 21:51 ` [PATCH 37/61] target/hppa: Decode CMPIB double-word Richard Henderson
2023-10-18 21:51 ` [PATCH 38/61] target/hppa: Decode ADDB double-word Richard Henderson
2023-10-18 21:51 ` [PATCH 39/61] target/hppa: Implement LDD, LDCD, LDDA, STD, STDA Richard Henderson
2023-10-18 21:51 ` [PATCH 40/61] target/hppa: Implement DEPD, DEPDI Richard Henderson
2023-10-18 21:51 ` [PATCH 41/61] target/hppa: Implement EXTRD Richard Henderson
2023-10-18 21:51 ` [PATCH 42/61] target/hppa: Implement SHRPD Richard Henderson
2023-10-18 21:51 ` [PATCH 43/61] target/hppa: Implement CLRBTS, POPBTS, PUSHBTS, PUSHNOM Richard Henderson
2023-10-18 21:51 ` [PATCH 44/61] target/hppa: Implement STDBY Richard Henderson
2023-10-18 21:51 ` [PATCH 45/61] target/hppa: Implement IDTLBT, IITLBT Richard Henderson
2023-10-18 21:51 ` [PATCH 46/61] target/hppa: Remove TARGET_REGISTER_BITS Richard Henderson
2023-10-18 21:51 ` [PATCH 47/61] target/hppa: Remove most of the TARGET_REGISTER_BITS redirections Richard Henderson
2023-10-18 21:51 ` [PATCH 48/61] target/hppa: Remove remaining " Richard Henderson
2023-10-18 21:51 ` [PATCH 49/61] target/hppa: Use tcg_temp_new_i64 not tcg_temp_new Richard Henderson
2023-10-18 21:51 ` [PATCH 50/61] target/hppa: Replace tcg_gen_*_tl with tcg_gen_*_i64 Richard Henderson
2023-10-18 21:51 ` [PATCH 51/61] target/hppa: Implement HADD Richard Henderson
2023-10-18 21:51 ` [PATCH 52/61] target/hppa: Implement HSUB Richard Henderson
2023-10-18 21:51 ` [PATCH 53/61] target/hppa: Implement HAVG Richard Henderson
2023-10-18 21:51 ` [PATCH 54/61] target/hppa: Implement HSHL, HSHR Richard Henderson
2023-10-18 21:51 ` [PATCH 55/61] target/hppa: Implement HSHLADD, HSHRADD Richard Henderson
2023-10-18 21:51 ` [PATCH 56/61] target/hppa: Implement MIXH, MIXW Richard Henderson
2023-10-18 21:51 ` [PATCH 57/61] target/hppa: Implement PERMH Richard Henderson
2023-10-18 21:51 ` [PATCH 58/61] target/hppa: Fix interruption based on default PSW Richard Henderson
2023-10-18 21:51 ` [PATCH 59/61] target/hppa: Precompute zero into DisasContext Richard Henderson
2023-10-18 21:51 ` [PATCH 60/61] target/hppa: Return zero for r0 from load_gpr Richard Henderson
2023-10-18 21:51 ` [PATCH 61/61] target/hppa: Simplify trans_dep*_imm Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018215135.1561375-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).