From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: mark.cave-ayland@ilande.co.uk, qemu-stable@nongnu.org
Subject: [PATCH v3 01/90] target/sparc: Clear may_lookup for npc == DYNAMIC_PC
Date: Fri, 20 Oct 2023 22:30:29 -0700 [thread overview]
Message-ID: <20231021053158.278135-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20231021053158.278135-1-richard.henderson@linaro.org>
With pairs of jmp+rett, pc == DYNAMIC_PC_LOOKUP and
npc == DYNAMIC_PC. Make sure that we exit for interrupts.
Cc: qemu-stable@nongnu.org
Fixes: 633c42834c7 ("target/sparc: Introduce DYNAMIC_PC_LOOKUP")
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/translate.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index f92ff80ac8..8fabed28fd 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -5654,10 +5654,10 @@ static void sparc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
break;
}
+ may_lookup = true;
if (dc->pc & 3) {
switch (dc->pc) {
case DYNAMIC_PC_LOOKUP:
- may_lookup = true;
break;
case DYNAMIC_PC:
may_lookup = false;
@@ -5667,10 +5667,24 @@ static void sparc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
}
} else {
tcg_gen_movi_tl(cpu_pc, dc->pc);
- may_lookup = true;
}
- save_npc(dc);
+ if (dc->npc & 3) {
+ switch (dc->npc) {
+ case JUMP_PC:
+ gen_generic_branch(dc);
+ break;
+ case DYNAMIC_PC:
+ may_lookup = false;
+ break;
+ case DYNAMIC_PC_LOOKUP:
+ break;
+ default:
+ g_assert_not_reached();
+ }
+ } else {
+ tcg_gen_movi_tl(cpu_npc, dc->npc);
+ }
if (may_lookup) {
tcg_gen_lookup_and_goto_ptr();
} else {
--
2.34.1
next prev parent reply other threads:[~2023-10-21 5:35 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 5:30 [PATCH v3 00/90] target/sparc: Convert to decodetree Richard Henderson
2023-10-21 5:30 ` Richard Henderson [this message]
2023-10-21 5:30 ` [PATCH v3 02/90] target/sparc: Implement check_align inline Richard Henderson
2023-10-21 5:30 ` [PATCH v3 03/90] target/sparc: Avoid helper_raise_exception in helper_st_asi Richard Henderson
2023-10-21 5:30 ` [PATCH v3 04/90] target/sparc: Set TCG_GUEST_DEFAULT_MO Richard Henderson
2023-10-21 5:30 ` [PATCH v3 05/90] configs: Enable MTTCG for sparc, sparc64 Richard Henderson
2023-10-21 5:30 ` [PATCH v3 06/90] target/sparc: Define features via cpu-feature.h.inc Richard Henderson
2023-10-21 5:30 ` [PATCH v3 07/90] target/sparc: Use CPU_FEATURE_BIT_* for cpu properties Richard Henderson
2023-10-21 5:30 ` [PATCH v3 08/90] target/sparc: Remove sparcv7 cpu features Richard Henderson
2023-10-21 5:30 ` [PATCH v3 09/90] target/sparc: Add decodetree infrastructure Richard Henderson
2023-10-21 5:30 ` [PATCH v3 10/90] target/sparc: Define AM_CHECK for sparc32 Richard Henderson
2023-10-21 5:30 ` [PATCH v3 11/90] target/sparc: Move CALL to decodetree Richard Henderson
2023-10-21 5:30 ` [PATCH v3 12/90] target/sparc: Move BPcc and Bicc " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 13/90] target/sparc: Move BPr " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 14/90] target/sparc: Move FBPfcc and FBfcc " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 15/90] target/sparc: Merge gen_cond with only caller Richard Henderson
2023-10-21 5:30 ` [PATCH v3 16/90] target/sparc: Merge gen_fcond " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 17/90] target/sparc: Merge gen_branch_[an] " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 18/90] target/sparc: Pass DisasCompare to advance_jump_cond Richard Henderson
2023-10-21 5:30 ` [PATCH v3 19/90] target/sparc: Move SETHI to decodetree Richard Henderson
2023-10-21 5:30 ` [PATCH v3 20/90] target/sparc: Move Tcc " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 21/90] target/sparc: Move RDASR, STBAR, MEMBAR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 22/90] target/sparc: Move RDPSR, RDHPR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 23/90] target/sparc: Move RDWIM, RDPR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 24/90] target/sparc: Move RDTBR, FLUSHW " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 25/90] target/sparc: Move WRASR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 26/90] target/sparc: Move WRPSR, SAVED, RESTORED " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 27/90] target/sparc: Move WRWIM, WRPR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 28/90] target/sparc: Move WRTBR, WRHPR " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 29/90] target/sparc: Move basic arithmetic " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 30/90] target/sparc: Move ADDC " Richard Henderson
2023-10-21 5:30 ` [PATCH v3 31/90] target/sparc: Move MULX " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 32/90] target/sparc: Move UMUL, SMUL " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 33/90] target/sparc: Move SUBC " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 34/90] target/sparc: Move UDIVX, SDIVX " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 35/90] target/sparc: Move UDIV, SDIV " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 36/90] target/sparc: Move TADD, TSUB, MULS " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 37/90] target/sparc: Move SLL, SRL, SRA " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 38/90] target/sparc: Move MOVcc, MOVR " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 39/90] target/sparc: Move POPC " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 40/90] target/sparc: Convert remaining v8 coproc insns " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 41/90] target/sparc: Move JMPL, RETT, RETURN " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 42/90] target/sparc: Move FLUSH, SAVE, RESTORE " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 43/90] target/sparc: Move DONE, RETRY " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 44/90] target/sparc: Split out resolve_asi Richard Henderson
2023-10-21 5:31 ` [PATCH v3 45/90] target/sparc: Drop ifdef around get_asi and friends Richard Henderson
2023-10-21 5:31 ` [PATCH v3 46/90] target/sparc: Split out ldst functions with asi pre-computed Richard Henderson
2023-10-21 5:31 ` [PATCH v3 47/90] target/sparc: Use tcg_gen_qemu_{ld, st}_i128 for GET_ASI_DTWINX Richard Henderson
2023-10-21 5:31 ` [PATCH v3 48/90] target/sparc: Move simple integer load/store to decodetree Richard Henderson
2023-10-21 5:31 ` [PATCH v3 49/90] target/sparc: Move asi " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 50/90] target/sparc: Move LDSTUB, LDSTUBA " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 51/90] target/sparc: Move SWAP, SWAPA " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 52/90] target/sparc: Move CASA, CASXA " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 53/90] target/sparc: Move PREFETCH, PREFETCHA " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 54/90] target/sparc: Split out fp ldst functions with asi precomputed Richard Henderson
2023-10-21 5:31 ` [PATCH v3 55/90] target/sparc: Move simple fp load/store to decodetree Richard Henderson
2023-10-21 5:31 ` [PATCH v3 56/90] target/sparc: Move asi " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 57/90] target/sparc: Move LDFSR, STFSR " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 58/90] target/sparc: Merge LDFSR, LDXFSR implementations Richard Henderson
2023-10-21 5:31 ` [PATCH v3 59/90] target/sparc: Move EDGE* to decodetree Richard Henderson
2023-10-21 5:31 ` [PATCH v3 60/90] target/sparc: Move ARRAY* " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 61/90] target/sparc: Move ADDRALIGN* " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 62/90] target/sparc: Move BMASK " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 63/90] target/sparc: Move FMOVS, FNEGS, FABSS, FSRC*S, FNOT*S " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 64/90] target/sparc: Move FMOVD, FNEGD, FABSD, FSRC*D, FNOT*D " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 65/90] target/sparc: Use tcg_gen_vec_{add,sub}* Richard Henderson
2023-10-21 5:31 ` [PATCH v3 66/90] target/sparc: Move gen_ne_fop_FFF insns to decodetree Richard Henderson
2023-10-21 5:31 ` [PATCH v3 67/90] target/sparc: Move gen_ne_fop_DDD " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 68/90] target/sparc: Move PDIST " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 69/90] target/sparc: Move gen_gsr_fop_DDD insns " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 70/90] target/sparc: Move gen_fop_FF " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 71/90] target/sparc: Move gen_fop_DD " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 72/90] target/sparc: Move FSQRTq " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 73/90] target/sparc: Move gen_fop_FFF insns " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 74/90] target/sparc: Move gen_fop_DDD " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 75/90] target/sparc: Move gen_fop_QQQ " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 76/90] target/sparc: Move FSMULD " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 77/90] target/sparc: Move FDMULQ " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 78/90] target/sparc: Move gen_fop_FD insns " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 79/90] target/sparc: Move FiTOd, FsTOd, FsTOx " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 80/90] target/sparc: Move FqTOs, FqTOi " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 81/90] target/sparc: Move FqTOd, FqTOx " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 82/90] target/sparc: Move FiTOq, FsTOq " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 83/90] target/sparc: Move FdTOq, FxTOq " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 84/90] target/sparc: Move FMOVq, FNEGq, FABSq " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 85/90] target/sparc: Move FMOVR, FMOVcc, FMOVfcc " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 86/90] target/sparc: Convert FCMP, FCMPE " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 87/90] target/sparc: Move FPCMP* " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 88/90] target/sparc: Move FPACK16, FPACKFIX " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 89/90] target/sparc: Convert FZERO, FONE " Richard Henderson
2023-10-21 5:31 ` [PATCH v3 90/90] target/sparc: Remove disas_sparc_legacy Richard Henderson
2023-10-21 14:07 ` [PATCH v3 00/90] target/sparc: Convert to decodetree Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231021053158.278135-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).