From: Thomas Huth <huth@tuxfamily.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple()
Date: Sun, 22 Oct 2023 11:42:06 +0200 [thread overview]
Message-ID: <20231022114206.767df917@fedora> (raw)
In-Reply-To: <20231020150627.56893-6-philmd@linaro.org>
Am Fri, 20 Oct 2023 17:06:25 +0200
schrieb Philippe Mathieu-Daudé <philmd@linaro.org>:
> Mechanical change using the following coccinelle script:
>
> @@
> identifier dev;
> identifier sbd;
> expression qom_type;
> expression addr;
> @@
> - dev = qdev_new(qom_type);
> - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, addr);
> + dev = sysbus_create_simple(qom_type, addr, NULL);
>
> then manually removing the 'dev' variable to avoid:
>
> error: variable 'dev' set but not used [-Werror,-Wunused-but-set-variable]
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Tested-by: Thomas Huth <huth@tuxfamily.org>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2023-10-22 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 15:06 [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses Philippe Mathieu-Daudé
2023-10-20 15:06 ` [PATCH 1/6] hw/m68k/irqc: Pass CPU using QOM link property Philippe Mathieu-Daudé
2023-10-22 9:18 ` Thomas Huth
2023-10-20 15:06 ` [PATCH 2/6] hw/m68k/mcf5206: " Philippe Mathieu-Daudé
2023-10-22 9:26 ` Thomas Huth
2023-10-20 15:06 ` [PATCH 3/6] hw/m68k/mcf_intc: Expose MMIO region via SysBus API Philippe Mathieu-Daudé
2023-10-22 9:32 ` Thomas Huth
2023-10-20 15:06 ` [PATCH 4/6] hw/m68k/mcf_intc: Pass CPU using QOM link property Philippe Mathieu-Daudé
2023-10-22 9:36 ` Thomas Huth
2023-10-20 15:06 ` [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple() Philippe Mathieu-Daudé
2023-10-22 9:42 ` Thomas Huth [this message]
2023-10-20 15:06 ` [PATCH 6/6] hw/m68k/virt: " Philippe Mathieu-Daudé
2023-10-22 9:43 ` Thomas Huth
2023-10-20 21:40 ` [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022114206.767df917@fedora \
--to=huth@tuxfamily.org \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).