From: titusr@google.com
To: philmd@linaro.org, minyard@acm.org
Cc: Titus Rwantare <titusr@google.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Benjamin Streb <bstreb@google.com>,
Corey Minyard <cminyard@mvista.com>
Subject: [PATCH v4 4/8] hw/i2c: pmbus: add VCAP register
Date: Mon, 23 Oct 2023 23:46:43 +0000 [thread overview]
Message-ID: <20231023-staging-pmbus-v3-v4-4-07a8cb7cd20a@google.com> (raw)
In-Reply-To: <20231023-staging-pmbus-v3-v4-0-07a8cb7cd20a@google.com>
VCAP is a register for devices with energy storage capacitors.
Reviewed-by: Benjamin Streb <bstreb@google.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Titus Rwantare <titusr@google.com>
---
hw/i2c/pmbus_device.c | 8 ++++++++
include/hw/i2c/pmbus_device.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c1d8c93056..3bce39e84e 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -906,6 +906,14 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)
}
break;
+ case PMBUS_READ_VCAP: /* Read-Only word */
+ if (pmdev->pages[index].page_flags & PB_HAS_VCAP) {
+ pmbus_send16(pmdev, pmdev->pages[index].read_vcap);
+ } else {
+ goto passthough;
+ }
+ break;
+
case PMBUS_READ_VOUT: /* Read-Only word */
if (pmdev->pages[index].page_flags & PB_HAS_VOUT) {
pmbus_send16(pmdev, pmdev->pages[index].read_vout);
diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h
index ad431bdc7c..f195c11384 100644
--- a/include/hw/i2c/pmbus_device.h
+++ b/include/hw/i2c/pmbus_device.h
@@ -243,6 +243,7 @@ OBJECT_DECLARE_TYPE(PMBusDevice, PMBusDeviceClass,
#define PB_HAS_VIN_RATING BIT_ULL(13)
#define PB_HAS_VOUT_RATING BIT_ULL(14)
#define PB_HAS_VOUT_MODE BIT_ULL(15)
+#define PB_HAS_VCAP BIT_ULL(16)
#define PB_HAS_IOUT BIT_ULL(21)
#define PB_HAS_IIN BIT_ULL(22)
#define PB_HAS_IOUT_RATING BIT_ULL(23)
--
2.42.0.758.gaed0368e0e-goog
next prev parent reply other threads:[~2023-10-23 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:46 [PATCH v4 0/8] PMBus fixes and new functions titusr
2023-10-23 23:46 ` [PATCH v4 1/8] hw/i2c: pmbus add support for block receive titusr
2023-10-23 23:46 ` [PATCH v4 2/8] hw/i2c: pmbus: add vout mode bitfields titusr
2023-10-23 23:46 ` [PATCH v4 3/8] hw/i2c: pmbus: add fan support titusr
2023-10-23 23:46 ` titusr [this message]
2023-10-23 23:46 ` [PATCH v4 5/8] hw/sensor: add ADM1266 device model titusr
2023-10-23 23:46 ` [PATCH v4 6/8] tests/qtest: add tests for ADM1266 titusr
2023-10-23 23:46 ` [PATCH v4 7/8] hw/i2c: pmbus: immediately clear faults on request titusr
2023-10-23 23:46 ` [PATCH v4 8/8] hw/i2c: pmbus: reset page register for out of range reads titusr
2023-10-24 9:58 ` [PATCH v4 0/8] PMBus fixes and new functions Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023-staging-pmbus-v3-v4-4-07a8cb7cd20a@google.com \
--to=titusr@google.com \
--cc=bstreb@google.com \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).