From: titusr@google.com
To: philmd@linaro.org, minyard@acm.org
Cc: Titus Rwantare <titusr@google.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Patrick Venture <venture@google.com>
Subject: [PATCH v4 7/8] hw/i2c: pmbus: immediately clear faults on request
Date: Mon, 23 Oct 2023 23:46:46 +0000 [thread overview]
Message-ID: <20231023-staging-pmbus-v3-v4-7-07a8cb7cd20a@google.com> (raw)
In-Reply-To: <20231023-staging-pmbus-v3-v4-0-07a8cb7cd20a@google.com>
The probing process of the generic pmbus driver generates
faults to determine if functions are available. These faults
were not always cleared resulting in probe failures.
Reviewed-by: Patrick Venture <venture@google.com>
Signed-off-by: Titus Rwantare <titusr@google.com>
---
hw/i2c/pmbus_device.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index 3bce39e84e..481e158380 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -1244,6 +1244,11 @@ static int pmbus_write_data(SMBusDevice *smd, uint8_t *buf, uint8_t len)
pmdev->in_buf = buf;
pmdev->code = buf[0]; /* PMBus command code */
+
+ if (pmdev->code == PMBUS_CLEAR_FAULTS) {
+ pmbus_clear_faults(pmdev);
+ }
+
if (len == 1) { /* Single length writes are command codes only */
return 0;
}
--
2.42.0.758.gaed0368e0e-goog
next prev parent reply other threads:[~2023-10-23 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:46 [PATCH v4 0/8] PMBus fixes and new functions titusr
2023-10-23 23:46 ` [PATCH v4 1/8] hw/i2c: pmbus add support for block receive titusr
2023-10-23 23:46 ` [PATCH v4 2/8] hw/i2c: pmbus: add vout mode bitfields titusr
2023-10-23 23:46 ` [PATCH v4 3/8] hw/i2c: pmbus: add fan support titusr
2023-10-23 23:46 ` [PATCH v4 4/8] hw/i2c: pmbus: add VCAP register titusr
2023-10-23 23:46 ` [PATCH v4 5/8] hw/sensor: add ADM1266 device model titusr
2023-10-23 23:46 ` [PATCH v4 6/8] tests/qtest: add tests for ADM1266 titusr
2023-10-23 23:46 ` titusr [this message]
2023-10-23 23:46 ` [PATCH v4 8/8] hw/i2c: pmbus: reset page register for out of range reads titusr
2023-10-24 9:58 ` [PATCH v4 0/8] PMBus fixes and new functions Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023-staging-pmbus-v3-v4-7-07a8cb7cd20a@google.com \
--to=titusr@google.com \
--cc=minyard@acm.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).