* [PATCH] qapi: Fix QAPISchemaEntity.__repr__()
@ 2023-10-24 10:48 Markus Armbruster
2023-10-24 12:02 ` Daniel P. Berrangé
2023-10-24 12:06 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Markus Armbruster @ 2023-10-24 10:48 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange, philmd
I messed it up on merge. It's a debugging aid, so no impact on build.
Fixes: e307a8174bb8 (qapi: provide a friendly string representation of QAPI classes)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/schema.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index d739e558e9..6a836950a9 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -76,7 +76,8 @@ def __init__(self, name: str, info, doc, ifcond=None, features=None):
def __repr__(self):
if self.name is None:
return "<%s at 0x%x>" % (type(self).__name__, id(self))
- return "<%s:%s at 0x%x>" % type(self).__name__, self.name, id(self)
+ return "<%s:%s at 0x%x>" % (type(self).__name__, self.name,
+ id(self))
def c_name(self):
return c_name(self.name)
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qapi: Fix QAPISchemaEntity.__repr__()
2023-10-24 10:48 [PATCH] qapi: Fix QAPISchemaEntity.__repr__() Markus Armbruster
@ 2023-10-24 12:02 ` Daniel P. Berrangé
2023-10-24 12:06 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-10-24 12:02 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, philmd
On Tue, Oct 24, 2023 at 12:48:41PM +0200, Markus Armbruster wrote:
> I messed it up on merge. It's a debugging aid, so no impact on build.
>
> Fixes: e307a8174bb8 (qapi: provide a friendly string representation of QAPI classes)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/schema.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qapi: Fix QAPISchemaEntity.__repr__()
2023-10-24 10:48 [PATCH] qapi: Fix QAPISchemaEntity.__repr__() Markus Armbruster
2023-10-24 12:02 ` Daniel P. Berrangé
@ 2023-10-24 12:06 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-24 12:06 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: berrange
On 24/10/23 12:48, Markus Armbruster wrote:
> I messed it up on merge. It's a debugging aid, so no impact on build.
>
> Fixes: e307a8174bb8 (qapi: provide a friendly string representation of QAPI classes)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/schema.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-24 12:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 10:48 [PATCH] qapi: Fix QAPISchemaEntity.__repr__() Markus Armbruster
2023-10-24 12:02 ` Daniel P. Berrangé
2023-10-24 12:06 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).