qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
	qemu-block@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Hailiang Zhang" <zhanghailiang@xfusion.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>, "Peter Xu" <peterx@redhat.com>,
	"Li Zhijian" <lizhijian@fujitsu.com>,
	"Leonardo Bras" <leobras@redhat.com>
Subject: [PATCH 11/12] migration: Remove transferred atomic counter
Date: Tue, 24 Oct 2023 17:10:41 +0200	[thread overview]
Message-ID: <20231024151042.90349-12-quintela@redhat.com> (raw)
In-Reply-To: <20231024151042.90349-1-quintela@redhat.com>

After last commit, it is a write only variable.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration-stats.h | 4 ----
 migration/multifd.c         | 3 ---
 migration/ram.c             | 1 -
 3 files changed, 8 deletions(-)

diff --git a/migration/migration-stats.h b/migration/migration-stats.h
index 68f3939188..05290ade76 100644
--- a/migration/migration-stats.h
+++ b/migration/migration-stats.h
@@ -97,10 +97,6 @@ typedef struct {
      * Number of bytes sent through RDMA.
      */
     Stat64 rdma_bytes;
-    /*
-     * Total number of bytes transferred.
-     */
-    Stat64 transferred;
     /*
      * Number of pages transferred that were full of zeros.
      */
diff --git a/migration/multifd.c b/migration/multifd.c
index e2a45c667a..ec58c58082 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -188,7 +188,6 @@ static int multifd_send_initial_packet(MultiFDSendParams *p, Error **errp)
         return -1;
     }
     stat64_add(&mig_stats.multifd_bytes, size);
-    stat64_add(&mig_stats.transferred, size);
     return 0;
 }
 
@@ -733,8 +732,6 @@ static void *multifd_send_thread(void *opaque)
 
             stat64_add(&mig_stats.multifd_bytes,
                        p->next_packet_size + p->packet_len);
-            stat64_add(&mig_stats.transferred,
-                       p->next_packet_size + p->packet_len);
             p->next_packet_size = 0;
             qemu_mutex_lock(&p->mutex);
             p->pending_job--;
diff --git a/migration/ram.c b/migration/ram.c
index 5ccf70333a..6d2bf50614 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -455,7 +455,6 @@ void ram_transferred_add(uint64_t bytes)
     } else {
         stat64_add(&mig_stats.downtime_bytes, bytes);
     }
-    stat64_add(&mig_stats.transferred, bytes);
 }
 
 struct MigrationOps {
-- 
2.41.0



  parent reply	other threads:[~2023-10-24 15:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 15:10 [PATCH 00/12] migration: Yet another round of atomic counters Juan Quintela
2023-10-24 15:10 ` [PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side Juan Quintela
2023-10-24 17:24   ` Fabiano Rosas
2023-10-25  9:00     ` Juan Quintela
2023-10-24 15:10 ` [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred Juan Quintela
2023-10-24 17:34   ` Fabiano Rosas
2023-10-24 18:14   ` Eric Blake
2023-10-25  9:01     ` Juan Quintela
2023-10-24 15:10 ` [PATCH 03/12] qemu_file: total_transferred is not used anymore Juan Quintela
2023-10-24 17:35   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 04/12] migration: Use the number of transferred bytes directly Juan Quintela
2023-10-24 17:40   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred() Juan Quintela
2023-10-24 17:40   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush() Juan Quintela
2023-10-24 17:42   ` Fabiano Rosas
2023-10-24 15:10 ` [PATCH 07/12] migration: migration_transferred_bytes() don't need the QEMUFile Juan Quintela
2023-10-24 15:10 ` [PATCH 08/12] migration: migration_rate_limit_reset() " Juan Quintela
2023-10-24 15:10 ` [PATCH 09/12] qemu-file: Simplify qemu_file_get_error() Juan Quintela
2023-10-24 15:10 ` [PATCH 10/12] migration: Use migration_transferred_bytes() Juan Quintela
2023-10-24 17:46   ` Fabiano Rosas
2023-10-24 15:10 ` Juan Quintela [this message]
2023-10-24 17:48   ` [PATCH 11/12] migration: Remove transferred atomic counter Fabiano Rosas
2023-10-24 15:10 ` [PATCH 12/12] qemu-file: Make qemu_fflush() return errors Juan Quintela
2023-10-24 17:56   ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024151042.90349-12-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=fam@euphon.net \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=lizhijian@fujitsu.com \
    --cc=peterx@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).