* [PATCH v2] misc/led: LED state is set opposite of what is expected
@ 2023-10-24 19:11 Glenn Miles
2023-10-27 6:03 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Miles @ 2023-10-24 19:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Glenn Miles, qemu-arm, clg, andrew, joel, philmd
Testing of the LED state showed that when the LED polarity was
set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on
the input GPIO of the LED, the LED was being turn off when it was
expected to be turned on.
Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
---
Changes from v1:
- Changed logic for readability
hw/misc/led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/led.c b/hw/misc/led.c
index f6d6d68bce..42bb43a39a 100644
--- a/hw/misc/led.c
+++ b/hw/misc/led.c
@@ -63,7 +63,7 @@ static void led_set_state_gpio_handler(void *opaque, int line, int new_state)
LEDState *s = LED(opaque);
assert(line == 0);
- led_set_state(s, !!new_state != s->gpio_active_high);
+ led_set_state(s, !!new_state == s->gpio_active_high);
}
static void led_reset(DeviceState *dev)
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] misc/led: LED state is set opposite of what is expected
2023-10-24 19:11 [PATCH v2] misc/led: LED state is set opposite of what is expected Glenn Miles
@ 2023-10-27 6:03 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2023-10-27 6:03 UTC (permalink / raw)
To: Glenn Miles, qemu-devel; +Cc: qemu-arm, clg, joel, philmd
On Tue, 2023-10-24 at 14:11 -0500, Glenn Miles wrote:
> Testing of the LED state showed that when the LED polarity was
> set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on
> the input GPIO of the LED, the LED was being turn off when it was
> expected to be turned on.
>
> Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 6:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 19:11 [PATCH v2] misc/led: LED state is set opposite of what is expected Glenn Miles
2023-10-27 6:03 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).