From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>,
Peter Xu <peterx@redhat.com>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
Fabiano Rosas <farosas@suse.de>,
Li Zhijian <lizhijian@fujitsu.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: [PATCH v2 05/12] qemu_file: Remove unused qemu_file_transferred()
Date: Wed, 25 Oct 2023 11:11:10 +0200 [thread overview]
Message-ID: <20231025091117.6342-6-quintela@redhat.com> (raw)
In-Reply-To: <20231025091117.6342-1-quintela@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/qemu-file.h | 18 ------------------
migration/qemu-file.c | 7 -------
2 files changed, 25 deletions(-)
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index a29c37b0d0..8b71152754 100644
--- a/migration/qemu-file.h
+++ b/migration/qemu-file.h
@@ -33,24 +33,6 @@ QEMUFile *qemu_file_new_input(QIOChannel *ioc);
QEMUFile *qemu_file_new_output(QIOChannel *ioc);
int qemu_fclose(QEMUFile *f);
-/*
- * qemu_file_transferred:
- *
- * Report the total number of bytes transferred with
- * this file.
- *
- * For writable files, any pending buffers will be
- * flushed, so the reported value will be equal to
- * the number of bytes transferred on the wire.
- *
- * For readable files, the reported value will be
- * equal to the number of bytes transferred on the
- * wire.
- *
- * Returns: the total bytes transferred
- */
-uint64_t qemu_file_transferred(QEMUFile *f);
-
/*
* qemu_file_transferred_noflush:
*
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 641ab703cc..efa5f11033 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -632,13 +632,6 @@ uint64_t qemu_file_transferred_noflush(QEMUFile *f)
return ret;
}
-uint64_t qemu_file_transferred(QEMUFile *f)
-{
- g_assert(qemu_file_is_writable(f));
- qemu_fflush(f);
- return stat64_get(&mig_stats.qemu_file_transferred);
-}
-
void qemu_put_be16(QEMUFile *f, unsigned int v)
{
qemu_put_byte(f, v >> 8);
--
2.41.0
next prev parent reply other threads:[~2023-10-25 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:11 [PATCH v2 00/12] migration: Yet another round of atomic counters Juan Quintela
2023-10-25 9:11 ` [PATCH v2 01/12] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer Juan Quintela
2023-10-25 13:14 ` Fabiano Rosas
2023-10-25 9:11 ` [PATCH v2 02/12] qemu_file: Use a stat64 for qemu_file_transferred Juan Quintela
2023-10-25 9:11 ` [PATCH v2 03/12] qemu_file: total_transferred is not used anymore Juan Quintela
2023-10-25 9:11 ` [PATCH v2 04/12] migration: Use the number of transferred bytes directly Juan Quintela
2023-10-25 9:11 ` Juan Quintela [this message]
2023-10-25 9:11 ` [PATCH v2 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush() Juan Quintela
2023-10-25 9:11 ` [PATCH v2 07/12] migration: migration_transferred_bytes() don't need the QEMUFile Juan Quintela
2023-10-25 9:11 ` [PATCH v2 08/12] migration: migration_rate_limit_reset() " Juan Quintela
2023-10-25 9:11 ` [PATCH v2 09/12] qemu-file: Simplify qemu_file_get_error() Juan Quintela
2023-10-25 9:11 ` [PATCH v2 10/12] migration: Use migration_transferred_bytes() Juan Quintela
2023-10-25 9:11 ` [PATCH v2 11/12] migration: Remove transferred atomic counter Juan Quintela
2023-10-25 9:11 ` [PATCH v2 12/12] qemu-file: Make qemu_fflush() return errors Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025091117.6342-6-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).