From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Brian Cain" <bcain@quicinc.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Kyle Evans" <kevans@freebsd.org>,
qemu-arm@nongnu.org,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Brad Smith" <brad@comstyle.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Cong Liu" <liucong2@kylinos.cn>
Subject: [PATCH 17/17] contrib/plugins: Close file descriptor on error return
Date: Sat, 28 Oct 2023 11:33:11 +0100 [thread overview]
Message-ID: <20231028103311.347104-18-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231028103311.347104-1-alex.bennee@linaro.org>
From: Cong Liu <liucong2@kylinos.cn>
This patch closes the file descriptor fd on error return to avoid
resource leak.
Fixes: ec7ee95db909 ("contrib/plugins: fix coverity warning in lockstep")
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Message-Id: <20231018025225.1640122-1-liucong2@kylinos.cn>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
contrib/plugins/lockstep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index f0cb8792c6..237543b43a 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -257,6 +257,7 @@ static bool setup_socket(const char *path)
sockaddr.sun_family = AF_UNIX;
if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
perror("bad path");
+ close(fd);
return false;
}
@@ -303,6 +304,7 @@ static bool connect_socket(const char *path)
sockaddr.sun_family = AF_UNIX;
if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
perror("bad path");
+ close(fd);
return false;
}
--
2.39.2
prev parent reply other threads:[~2023-10-28 10:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 10:32 [PATCH 00/17] Maintainer updates for testing, gdb, semihosting and plugins Alex Bennée
2023-10-28 10:32 ` [PATCH 01/17] tests/vm/openbsd: Use the system dtc package Alex Bennée
2023-10-28 10:32 ` [PATCH 02/17] tests/tcg: Add -fno-stack-protector Alex Bennée
2023-10-28 19:14 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 03/17] gitlab: split alpha testing into a legacy container Alex Bennée
2023-10-28 19:19 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 04/17] tests/docker: use debian-legacy-test-cross for alpha Alex Bennée
2023-10-28 19:20 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 05/17] tests/docker: move sh4 to use debian-legacy-test-cross Alex Bennée
2023-10-28 19:22 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 06/17] tests/docker: use debian-all-test-cross for power Alex Bennée
2023-10-28 19:23 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 07/17] tests/docker: use debian-all-test-cross for hppa Alex Bennée
2023-10-28 19:23 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 08/17] tests/docker: use debian-all-test-cross for m68k Alex Bennée
2023-10-28 19:24 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 09/17] tests/docker: use debian-all-test-cross for mips64 Alex Bennée
2023-10-28 19:24 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 10/17] tests/docker: use debian-all-test-cross for mips Alex Bennée
2023-10-28 19:25 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 11/17] tests/docker: use debian-all-test-cross for riscv64 Alex Bennée
2023-10-28 19:26 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 12/17] tests/docker: use debian-all-test-cross for sparc64 Alex Bennée
2023-10-28 19:27 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 13/17] tests/docker: upgrade debian-all-test-cross to bookworm Alex Bennée
2023-10-28 19:29 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 14/17] gdbstub: Check if gdb_regs is NULL Alex Bennée
2023-10-28 19:30 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 15/17] semihosting: fix memleak at semihosting_arg_fallback Alex Bennée
2023-10-28 19:31 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 16/17] plugins: Remove an extra parameter Alex Bennée
2023-10-28 17:54 ` Richard Henderson
2023-10-28 10:33 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028103311.347104-18-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=bcain@quicinc.com \
--cc=bleal@redhat.com \
--cc=brad@comstyle.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=imp@bsdimp.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kevans@freebsd.org \
--cc=liucong2@kylinos.cn \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).