From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Brian Cain" <bcain@quicinc.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Kyle Evans" <kevans@freebsd.org>,
qemu-arm@nongnu.org,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Brad Smith" <brad@comstyle.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: [PATCH 08/17] tests/docker: use debian-all-test-cross for m68k
Date: Sat, 28 Oct 2023 11:33:02 +0100 [thread overview]
Message-ID: <20231028103311.347104-9-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231028103311.347104-1-alex.bennee@linaro.org>
Maintaining two sets of containers for test building is silly. While
it makes sense for the QEMU cross-compile targets to have their own
fat containers built by lcitool we might as well merge the other
random debian based compilers into the same one used on gitlab.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 5 +++++
.gitlab-ci.d/container-cross.yml | 6 ------
tests/docker/Makefile.include | 2 +-
.../dockerfiles/debian-m68k-cross.docker | 19 -------------------
4 files changed, 6 insertions(+), 26 deletions(-)
delete mode 100644 tests/docker/dockerfiles/debian-m68k-cross.docker
diff --git a/configure b/configure
index 0a755c71a0..c7c811fb02 100755
--- a/configure
+++ b/configure
@@ -1313,6 +1313,11 @@ probe_target_compiler() {
container_image=debian-loongarch-cross
container_cross_prefix=loongarch64-unknown-linux-gnu-
;;
+ m68k)
+ container_image=debian-all-test-cross
+ container_cross_prefix=m68k-linux-gnu-
+ container_cross_cc=${container_cross_prefix}gcc
+ ;;
microblaze)
container_image=debian-microblaze-cross
container_cross_prefix=microblaze-linux-musl-
diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml
index 5f8616c0fd..cf2fcaa59e 100644
--- a/.gitlab-ci.d/container-cross.yml
+++ b/.gitlab-ci.d/container-cross.yml
@@ -40,12 +40,6 @@ hexagon-cross-container:
variables:
NAME: debian-hexagon-cross
-m68k-debian-cross-container:
- extends: .container_job_template
- stage: containers
- variables:
- NAME: debian-m68k-cross
-
mips64-debian-cross-container:
extends: .container_job_template
stage: containers
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index b701f1225a..f482b1e92d 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -123,7 +123,7 @@ docker-image-debian-nios2-cross: $(DOCKER_FILES_DIR)/debian-toolchain.docker \
# These images may be good enough for building tests but not for test builds
DOCKER_PARTIAL_IMAGES += debian-loongarch-cross
-DOCKER_PARTIAL_IMAGES += debian-m68k-cross debian-mips64-cross
+DOCKER_PARTIAL_IMAGES += debian-mips64-cross
DOCKER_PARTIAL_IMAGES += debian-microblaze-cross
DOCKER_PARTIAL_IMAGES += debian-mips-cross
DOCKER_PARTIAL_IMAGES += debian-nios2-cross
diff --git a/tests/docker/dockerfiles/debian-m68k-cross.docker b/tests/docker/dockerfiles/debian-m68k-cross.docker
deleted file mode 100644
index 25dd1c1e68..0000000000
--- a/tests/docker/dockerfiles/debian-m68k-cross.docker
+++ /dev/null
@@ -1,19 +0,0 @@
-#
-# Docker cross-compiler target
-#
-# This docker target builds on the Debian Bullseye base image.
-#
-FROM docker.io/library/debian:11-slim
-
-RUN export DEBIAN_FRONTEND=noninteractive && \
- apt-get update && \
- apt-get install -y eatmydata && \
- eatmydata apt-get dist-upgrade -y && \
- eatmydata apt-get install --no-install-recommends -y \
- gcc-m68k-linux-gnu \
- libc6-dev-m68k-cross
-# As a final step configure the user (if env is defined)
-ARG USER
-ARG UID
-RUN if [ "${USER}" ]; then \
- id ${USER} 2>/dev/null || useradd -u ${UID} -U ${USER}; fi
--
2.39.2
next prev parent reply other threads:[~2023-10-28 10:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 10:32 [PATCH 00/17] Maintainer updates for testing, gdb, semihosting and plugins Alex Bennée
2023-10-28 10:32 ` [PATCH 01/17] tests/vm/openbsd: Use the system dtc package Alex Bennée
2023-10-28 10:32 ` [PATCH 02/17] tests/tcg: Add -fno-stack-protector Alex Bennée
2023-10-28 19:14 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 03/17] gitlab: split alpha testing into a legacy container Alex Bennée
2023-10-28 19:19 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 04/17] tests/docker: use debian-legacy-test-cross for alpha Alex Bennée
2023-10-28 19:20 ` Richard Henderson
2023-10-28 10:32 ` [PATCH 05/17] tests/docker: move sh4 to use debian-legacy-test-cross Alex Bennée
2023-10-28 19:22 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 06/17] tests/docker: use debian-all-test-cross for power Alex Bennée
2023-10-28 19:23 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 07/17] tests/docker: use debian-all-test-cross for hppa Alex Bennée
2023-10-28 19:23 ` Richard Henderson
2023-10-28 10:33 ` Alex Bennée [this message]
2023-10-28 19:24 ` [PATCH 08/17] tests/docker: use debian-all-test-cross for m68k Richard Henderson
2023-10-28 10:33 ` [PATCH 09/17] tests/docker: use debian-all-test-cross for mips64 Alex Bennée
2023-10-28 19:24 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 10/17] tests/docker: use debian-all-test-cross for mips Alex Bennée
2023-10-28 19:25 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 11/17] tests/docker: use debian-all-test-cross for riscv64 Alex Bennée
2023-10-28 19:26 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 12/17] tests/docker: use debian-all-test-cross for sparc64 Alex Bennée
2023-10-28 19:27 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 13/17] tests/docker: upgrade debian-all-test-cross to bookworm Alex Bennée
2023-10-28 19:29 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 14/17] gdbstub: Check if gdb_regs is NULL Alex Bennée
2023-10-28 19:30 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 15/17] semihosting: fix memleak at semihosting_arg_fallback Alex Bennée
2023-10-28 19:31 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 16/17] plugins: Remove an extra parameter Alex Bennée
2023-10-28 17:54 ` Richard Henderson
2023-10-28 10:33 ` [PATCH 17/17] contrib/plugins: Close file descriptor on error return Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028103311.347104-9-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=bcain@quicinc.com \
--cc=bleal@redhat.com \
--cc=brad@comstyle.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=imp@bsdimp.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kevans@freebsd.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).