From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Brad Smith" <brad@comstyle.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>, "Warner Losh" <imp@bsdimp.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>,
"Brian Cain" <bcain@quicinc.com>,
"Alexandre Iooss" <erdnaxe@crans.org>
Subject: [PATCH v2 07/19] tests/docker: move sh4 to use debian-legacy-test-cross
Date: Sun, 29 Oct 2023 14:50:21 +0000 [thread overview]
Message-ID: <20231029145033.592566-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231029145033.592566-1-alex.bennee@linaro.org>
sh4 is another target which doesn't work with bookworm compilers. To
keep on buster move across to the debian-legacy-test-cross image and
update accordingly.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231028103311.347104-6-alex.bennee@linaro.org>
---
v2
- fix missing exclude from build-user
- merge fixes
---
configure | 4 ++++
.gitlab-ci.d/buildtest.yml | 4 ++--
.gitlab-ci.d/container-cross.yml | 6 ------
tests/docker/Makefile.include | 2 +-
.../dockerfiles/debian-all-test-cross.docker | 4 +---
.../debian-legacy-test-cross.docker | 3 ++-
.../dockerfiles/debian-sh4-cross.docker | 19 -------------------
7 files changed, 10 insertions(+), 32 deletions(-)
delete mode 100644 tests/docker/dockerfiles/debian-sh4-cross.docker
diff --git a/configure b/configure
index c8d0d4f7cb..37d1b10b87 100755
--- a/configure
+++ b/configure
@@ -1334,6 +1334,10 @@ probe_target_compiler() {
container_cross_prefix=powerpc${target_arch#ppc}-linux-gnu-
container_cross_cc=${container_cross_prefix}gcc-10
;;
+ sh4)
+ container_image=debian-legacy-test-cross
+ container_cross_prefix=sh4-linux-gnu-
+ ;;
tricore)
container_image=debian-tricore-cross
container_cross_prefix=tricore-
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 9500ea6e2c..b66d05038f 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -266,7 +266,7 @@ build-user-static:
variables:
IMAGE: debian-all-test-cross
CONFIGURE_ARGS: --disable-tools --disable-system --static
- --target-list-exclude=alpha-linux-user
+ --target-list-exclude=alpha-linux-user,sh4-linux-user
MAKE_CHECK_ARGS: check-tcg
# targets stuck on older compilers
@@ -276,7 +276,7 @@ build-legacy:
job: amd64-debian-legacy-cross-container
variables:
IMAGE: debian-legacy-test-cross
- TARGETS: alpha-linux-user alpha-softmmu
+ TARGETS: alpha-linux-user alpha-softmmu sh4-linux-user
CONFIGURE_ARGS: --disable-tools
MAKE_CHECK_ARGS: check-tcg
diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml
index 0de1929e74..3e6d741f62 100644
--- a/.gitlab-ci.d/container-cross.yml
+++ b/.gitlab-ci.d/container-cross.yml
@@ -116,12 +116,6 @@ s390x-debian-cross-container:
variables:
NAME: debian-s390x-cross
-sh4-debian-cross-container:
- extends: .container_job_template
- stage: containers
- variables:
- NAME: debian-sh4-cross
-
sparc64-debian-cross-container:
extends: .container_job_template
stage: containers
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 8270bdff6c..f61d97102f 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -129,7 +129,7 @@ DOCKER_PARTIAL_IMAGES += debian-microblaze-cross
DOCKER_PARTIAL_IMAGES += debian-mips-cross
DOCKER_PARTIAL_IMAGES += debian-nios2-cross
DOCKER_PARTIAL_IMAGES += debian-riscv64-test-cross
-DOCKER_PARTIAL_IMAGES += debian-sh4-cross debian-sparc64-cross
+DOCKER_PARTIAL_IMAGES += debian-sparc64-cross
DOCKER_PARTIAL_IMAGES += debian-xtensa-cross
DOCKER_PARTIAL_IMAGES += fedora-cris-cross
diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker
index 205173b0a5..43cc083318 100644
--- a/tests/docker/dockerfiles/debian-all-test-cross.docker
+++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
@@ -52,8 +52,6 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
libc6-dev-riscv64-cross \
gcc-s390x-linux-gnu \
libc6-dev-s390x-cross \
- gcc-sh4-linux-gnu \
- libc6-dev-sh4-cross \
gcc-sparc64-linux-gnu \
libc6-dev-sparc64-cross \
python3-pip \
@@ -64,7 +62,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
RUN /usr/bin/pip3 install tomli
ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
-ENV DEF_TARGET_LIST aarch64-linux-user,arm-linux-user,hppa-linux-user,i386-linux-user,m68k-linux-user,mips-linux-user,mips64-linux-user,mips64el-linux-user,mipsel-linux-user,ppc-linux-user,ppc64-linux-user,ppc64le-linux-user,riscv64-linux-user,s390x-linux-user,sh4-linux-user,sparc64-linux-user
+ENV DEF_TARGET_LIST aarch64-linux-user,arm-linux-user,hppa-linux-user,i386-linux-user,m68k-linux-user,mips-linux-user,mips64-linux-user,mips64el-linux-user,mipsel-linux-user,ppc-linux-user,ppc64-linux-user,ppc64le-linux-user,riscv64-linux-user,s390x-linux-user,sparc64-linux-user
# As a final step configure the user (if env is defined)
ARG USER
ARG UID
diff --git a/tests/docker/dockerfiles/debian-legacy-test-cross.docker b/tests/docker/dockerfiles/debian-legacy-test-cross.docker
index 763d36dfe3..d9b37995a2 100644
--- a/tests/docker/dockerfiles/debian-legacy-test-cross.docker
+++ b/tests/docker/dockerfiles/debian-legacy-test-cross.docker
@@ -4,6 +4,7 @@
# upgrade. Currently:
#
# libc6.1-dev-alpha-cross: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054412
+# sh4-linux-user: binaries don't run with bookworm compiler
#
# As we are targeting check-tcg here we only need minimal qemu
# dependencies and the relevant cross compilers.
@@ -38,7 +39,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
RUN /usr/bin/pip3 install tomli
ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
-ENV DEF_TARGET_LIST alpha-linux-user
+ENV DEF_TARGET_LIST alpha-linux-user,sh4-linux-user
# As a final step configure the user (if env is defined)
ARG USER
ARG UID
diff --git a/tests/docker/dockerfiles/debian-sh4-cross.docker b/tests/docker/dockerfiles/debian-sh4-cross.docker
deleted file mode 100644
index 6bd8171d33..0000000000
--- a/tests/docker/dockerfiles/debian-sh4-cross.docker
+++ /dev/null
@@ -1,19 +0,0 @@
-#
-# Docker cross-compiler target
-#
-# This docker target builds on the Debian Bullseye base image.
-#
-FROM docker.io/library/debian:11-slim
-
-RUN export DEBIAN_FRONTEND=noninteractive && \
- apt-get update && \
- apt-get install -y eatmydata && \
- eatmydata apt-get dist-upgrade -y && \
- eatmydata apt-get install --no-install-recommends -y \
- gcc-sh4-linux-gnu \
- libc6-dev-sh4-cross
-# As a final step configure the user (if env is defined)
-ARG USER
-ARG UID
-RUN if [ "${USER}" ]; then \
- id ${USER} 2>/dev/null || useradd -u ${UID} -U ${USER}; fi
--
2.39.2
next prev parent reply other threads:[~2023-10-29 14:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 14:50 [PATCH v2 00/19] Maintainer updates for testing, gdb, semihosting and plugins (pre-PR) Alex Bennée
2023-10-29 14:50 ` [PATCH v2 01/19] tests/vm/openbsd: Use the system dtc package Alex Bennée
2023-10-29 14:50 ` [PATCH v2 02/19] tests/tcg: Add -fno-stack-protector Alex Bennée
2023-10-29 14:50 ` [PATCH v2 03/19] gitlab: split alpha testing into a legacy container Alex Bennée
2023-10-29 16:47 ` Richard Henderson
2023-10-29 14:50 ` [PATCH v2 04/19] gitlab: clean-up build-soft-softmmu job Alex Bennée
2023-10-29 16:48 ` Richard Henderson
2023-10-29 14:50 ` [PATCH v2 05/19] gitlab: add build-loongarch to matrix Alex Bennée
2023-10-29 16:57 ` Richard Henderson
2023-10-29 14:50 ` [PATCH v2 06/19] tests/docker: use debian-legacy-test-cross for alpha Alex Bennée
2023-10-29 14:50 ` Alex Bennée [this message]
2023-10-29 18:52 ` [PATCH v2 07/19] tests/docker: move sh4 to use debian-legacy-test-cross Richard Henderson
2023-10-30 13:57 ` [PATCH v3] " Alex Bennée
2023-10-30 20:25 ` Richard Henderson
2023-10-29 14:50 ` [PATCH v2 08/19] tests/docker: use debian-all-test-cross for power Alex Bennée
2023-10-29 14:50 ` [PATCH v2 09/19] tests/docker: use debian-all-test-cross for hppa Alex Bennée
2023-10-29 14:50 ` [PATCH v2 10/19] tests/docker: use debian-all-test-cross for m68k Alex Bennée
2023-10-29 14:50 ` [PATCH v2 11/19] tests/docker: use debian-all-test-cross for mips64 Alex Bennée
2023-10-29 14:50 ` [PATCH v2 12/19] tests/docker: use debian-all-test-cross for mips Alex Bennée
2023-10-29 14:50 ` [PATCH v2 13/19] tests/docker: use debian-all-test-cross for riscv64 Alex Bennée
2023-10-29 14:50 ` [PATCH v2 14/19] tests/docker: use debian-all-test-cross for sparc64 Alex Bennée
2023-10-29 19:02 ` Richard Henderson
2023-10-29 14:50 ` [PATCH v2 15/19] tests/docker: upgrade debian-all-test-cross to bookworm Alex Bennée
2023-10-29 14:50 ` [PATCH v2 16/19] gdbstub: Check if gdb_regs is NULL Alex Bennée
2023-10-29 14:50 ` [PATCH v2 17/19] semihosting: fix memleak at semihosting_arg_fallback Alex Bennée
2023-10-29 14:50 ` [PATCH v2 18/19] plugins: Remove an extra parameter Alex Bennée
2023-10-29 14:50 ` [PATCH v2 19/19] contrib/plugins: Close file descriptor on error return Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029145033.592566-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=bcain@quicinc.com \
--cc=bleal@redhat.com \
--cc=brad@comstyle.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=imp@bsdimp.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kevans@freebsd.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).