From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com,
peter.maydell@linaro.org, pbonzini@redhat.com, philmd@linaro.org
Subject: [PATCH v2 03/12] hw/arm/mps2-tz: Use qdev_prop_set_array()
Date: Mon, 30 Oct 2023 15:26:49 +0100 [thread overview]
Message-ID: <20231030142658.182193-4-kwolf@redhat.com> (raw)
In-Reply-To: <20231030142658.182193-1-kwolf@redhat.com>
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/mps2-tz.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c
index eae3639da2..668db5ed61 100644
--- a/hw/arm/mps2-tz.c
+++ b/hw/arm/mps2-tz.c
@@ -48,6 +48,7 @@
#include "qemu/units.h"
#include "qemu/cutils.h"
#include "qapi/error.h"
+#include "qapi/qmp/qlist.h"
#include "qemu/error-report.h"
#include "hw/arm/boot.h"
#include "hw/arm/armv7m.h"
@@ -461,6 +462,7 @@ static MemoryRegion *make_scc(MPS2TZMachineState *mms, void *opaque,
MPS2SCC *scc = opaque;
DeviceState *sccdev;
MPS2TZMachineClass *mmc = MPS2TZ_MACHINE_GET_CLASS(mms);
+ QList *oscclk;
uint32_t i;
object_initialize_child(OBJECT(mms), "scc", scc, TYPE_MPS2_SCC);
@@ -469,11 +471,13 @@ static MemoryRegion *make_scc(MPS2TZMachineState *mms, void *opaque,
qdev_prop_set_uint32(sccdev, "scc-cfg4", 0x2);
qdev_prop_set_uint32(sccdev, "scc-aid", 0x00200008);
qdev_prop_set_uint32(sccdev, "scc-id", mmc->scc_id);
- qdev_prop_set_uint32(sccdev, "len-oscclk", mmc->len_oscclk);
+
+ oscclk = qlist_new();
for (i = 0; i < mmc->len_oscclk; i++) {
- g_autofree char *propname = g_strdup_printf("oscclk[%u]", i);
- qdev_prop_set_uint32(sccdev, propname, mmc->oscclk[i]);
+ qlist_append_int(oscclk, mmc->oscclk[i]);
}
+ qdev_prop_set_array(sccdev, "oscclk", oscclk);
+
sysbus_realize(SYS_BUS_DEVICE(scc), &error_fatal);
return sysbus_mmio_get_region(SYS_BUS_DEVICE(sccdev), 0);
}
--
2.41.0
next prev parent reply other threads:[~2023-10-30 14:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 14:26 [PATCH v2 00/12] qdev: Make array properties user accessible again Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 01/12] qdev: Add qdev_prop_set_array() Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 02/12] hw/i386/pc: Use qdev_prop_set_array() Kevin Wolf
2023-10-30 14:26 ` Kevin Wolf [this message]
2023-10-30 14:26 ` [PATCH v2 04/12] hw/arm/mps2: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 05/12] hw/arm/sbsa-ref: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 06/12] hw/arm/vexpress: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 07/12] hw/arm/virt: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 08/12] hw/arm/xlnx-versal: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 09/12] hw/rx/rx62n: " Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 10/12] qom: Add object_property_set_default_list() Kevin Wolf
2023-10-30 14:26 ` [PATCH v2 11/12] qdev: Make netdev properties work as list elements Kevin Wolf
2023-11-02 12:55 ` Markus Armbruster
2023-11-07 13:35 ` Kevin Wolf
2023-11-08 6:50 ` Markus Armbruster
2023-10-30 14:26 ` [PATCH v2 12/12] qdev: Rework array properties based on list visitor Kevin Wolf
2023-10-30 20:48 ` Mark Cave-Ayland
2023-10-31 11:09 ` Kevin Wolf
2023-11-02 13:29 ` Markus Armbruster
2023-11-03 12:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030142658.182193-4-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).