qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 01/21] linux-user: Fix guest signal remapping after adjusting SIGABRT
Date: Mon, 30 Oct 2023 14:17:07 -0700	[thread overview]
Message-ID: <20231030211727.165090-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20231030211727.165090-1-richard.henderson@linaro.org>

The arithmetic within the loop was not adjusted properly after SIGRTMIN
was stolen for the guest SIGABRT.  The effect was that the guest libc
could not send itself __SIGRTMIN to wake sleeping threads.

Fixes: 38ee0a7dfb4b ("linux-user: Remap guest SIGABRT")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1967
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/signal.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index 3b8efec89f..b35d1e512f 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -536,11 +536,10 @@ static void signal_table_init(void)
     host_to_target_signal_table[SIGABRT] = 0;
     host_to_target_signal_table[hsig++] = TARGET_SIGABRT;
 
-    for (; hsig <= SIGRTMAX; hsig++) {
-        tsig = hsig - SIGRTMIN + TARGET_SIGRTMIN;
-        if (tsig <= TARGET_NSIG) {
-            host_to_target_signal_table[hsig] = tsig;
-        }
+    for (tsig = TARGET_SIGRTMIN;
+         hsig <= SIGRTMAX && tsig <= TARGET_NSIG;
+         hsig++, tsig++) {
+        host_to_target_signal_table[hsig] = tsig;
     }
 
     /* Invert the mapping that has already been assigned. */
-- 
2.34.1



  reply	other threads:[~2023-10-30 21:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 21:17 [PULL 00/21] linux-user patch queue Richard Henderson
2023-10-30 21:17 ` Richard Henderson [this message]
2023-10-30 21:17 ` [PULL 02/21] linux-user: Introduce imgsrc_read, imgsrc_read_alloc Richard Henderson
2023-10-30 21:17 ` [PULL 03/21] linux-user: Tidy loader_exec Richard Henderson
2023-10-30 21:17 ` [PULL 04/21] linux-user: Do not clobber bprm_buf swapping ehdr Richard Henderson
2023-10-30 21:17 ` [PULL 05/21] linux-user: Use ImageSource in load_elf_image Richard Henderson
2023-10-30 21:17 ` [PULL 06/21] linux-user: Use ImageSource in load_symbols Richard Henderson
2023-10-30 21:17 ` [PULL 07/21] linux-user: Replace bprm->fd with bprm->src.fd Richard Henderson
2023-10-30 21:17 ` [PULL 08/21] linux-user: Load vdso image if available Richard Henderson
2023-10-30 21:17 ` [PULL 09/21] linux-user: Add gen-vdso tool Richard Henderson
2023-11-02 12:49   ` Peter Maydell
2023-10-30 21:17 ` [PULL 10/21] linux-user/i386: Add vdso Richard Henderson
2023-10-30 21:17 ` [PULL 11/21] linux-user/x86_64: " Richard Henderson
2023-10-30 21:17 ` [PULL 12/21] linux-user/aarch64: " Richard Henderson
2023-10-30 21:17 ` [PULL 13/21] linux-user/arm: " Richard Henderson
2023-10-30 21:17 ` [PULL 14/21] linux-user/hppa: " Richard Henderson
2023-10-30 21:17 ` [PULL 15/21] linux-user/riscv: " Richard Henderson
2024-01-11 21:49   ` Vineet Gupta
2024-01-12 21:35     ` Richard Henderson
2024-01-12 23:04       ` Palmer Dabbelt
2024-01-12 23:37       ` Vineet Gupta
2024-01-12 23:58         ` Vineet Gupta
2024-01-13  0:05         ` Richard Henderson
2024-01-13  0:22           ` Vineet Gupta
2024-01-14 23:52             ` Richard Henderson
2023-10-30 21:17 ` [PULL 16/21] linux-user/loongarch64: " Richard Henderson
2023-10-30 21:17 ` [PULL 17/21] linux-user/ppc: " Richard Henderson
2023-10-30 21:17 ` [PULL 18/21] linux-user/s390x: Rename __SIGNAL_FRAMESIZE to STACK_FRAME_OVERHEAD Richard Henderson
2023-10-30 21:17 ` [PULL 19/21] linux-user/s390x: Add vdso Richard Henderson
2023-10-30 21:17 ` [PULL 20/21] linux-user: Show vdso address in /proc/pid/maps Richard Henderson
2023-10-30 21:17 ` [PULL 21/21] build: Add update-linux-vdso makefile rule Richard Henderson
2023-10-31  7:51 ` [PULL 00/21] linux-user patch queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231030211727.165090-2-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).