From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>
Subject: Re: tests/data/acpi/rebuild-expected-aml.sh creates files for arm virt that don't exist in git
Date: Tue, 31 Oct 2023 09:51:21 -0400 [thread overview]
Message-ID: <20231031094948-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA_qBLXdeB7aQLcjcfMdEf9hpJu4ZhZZdHbF4SOSyZZXdw@mail.gmail.com>
On Tue, Oct 31, 2023 at 01:08:01PM +0000, Peter Maydell wrote:
> I'm doing a patchset that requires rebuilding the bios-tables-test
> expected-data files for the arm virt board. The instructions in
> bios-tables-test.c say that you should run rebuild-expected-aml.sh
> to update the data files. But running that script generates a lot
> of new data files that don't exist in git at all and are unrelated
> to the change I'm making:
>
> tests/data/acpi/virt/APIC.memhp
> tests/data/acpi/virt/APIC.numamem
> tests/data/acpi/virt/APIC.pxb
> tests/data/acpi/virt/DBG2.acpihmatvirt
> tests/data/acpi/virt/DBG2.memhp
> tests/data/acpi/virt/DBG2.numamem
> tests/data/acpi/virt/DBG2.pxb
> tests/data/acpi/virt/DBG2.topology
> tests/data/acpi/virt/DSDT.numamem
> tests/data/acpi/virt/FACP.acpihmatvirt
> tests/data/acpi/virt/FACP.memhp
> tests/data/acpi/virt/FACP.numamem
> tests/data/acpi/virt/FACP.pxb
> tests/data/acpi/virt/FACP.topology
> tests/data/acpi/virt/GTDT.acpihmatvirt
> tests/data/acpi/virt/GTDT.memhp
> tests/data/acpi/virt/GTDT.numamem
> tests/data/acpi/virt/GTDT.pxb
> tests/data/acpi/virt/GTDT.topology
> tests/data/acpi/virt/IORT.acpihmatvirt
> tests/data/acpi/virt/IORT.memhp
> tests/data/acpi/virt/IORT.numamem
> tests/data/acpi/virt/IORT.pxb
> tests/data/acpi/virt/IORT.topology
> tests/data/acpi/virt/MCFG.acpihmatvirt
> tests/data/acpi/virt/MCFG.memhp
> tests/data/acpi/virt/MCFG.numamem
> tests/data/acpi/virt/MCFG.pxb
> tests/data/acpi/virt/MCFG.topology
> tests/data/acpi/virt/PPTT.memhp
> tests/data/acpi/virt/PPTT.numamem
> tests/data/acpi/virt/PPTT.pxb
> tests/data/acpi/virt/SPCR.acpihmatvirt
> tests/data/acpi/virt/SPCR.memhp
> tests/data/acpi/virt/SPCR.numamem
> tests/data/acpi/virt/SPCR.pxb
> tests/data/acpi/virt/SPCR.topology
>
> Does the script need fixing to not generate these files, or should
> they exist in the git repo?
The script is not smart enough to notice that files are identical - e.g.
tests/data/acpi/virt/PPTT are all the same so we just have one of these
- and so all the copies don't need to be there. Just check and then blow
away the unnecessary files.
--
MST
next prev parent reply other threads:[~2023-10-31 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 13:08 tests/data/acpi/rebuild-expected-aml.sh creates files for arm virt that don't exist in git Peter Maydell
2023-10-31 13:51 ` Michael S. Tsirkin [this message]
2023-10-31 14:01 ` Ani Sinha
2023-10-31 13:54 ` Ani Sinha
2023-10-31 13:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031094948-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).