From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 10/19] tests/docker: use debian-all-test-cross for m68k
Date: Tue, 31 Oct 2023 14:43:52 +0000 [thread overview]
Message-ID: <20231031144401.1238210-11-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231031144401.1238210-1-alex.bennee@linaro.org>
Maintaining two sets of containers for test building is silly. While
it makes sense for the QEMU cross-compile targets to have their own
fat containers built by lcitool we might as well merge the other
random debian based compilers into the same one used on gitlab.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231029145033.592566-11-alex.bennee@linaro.org>
diff --git a/configure b/configure
index be7cfeddc0..aa29cfb797 100755
--- a/configure
+++ b/configure
@@ -1313,6 +1313,11 @@ probe_target_compiler() {
container_image=debian-loongarch-cross
container_cross_prefix=loongarch64-unknown-linux-gnu-
;;
+ m68k)
+ container_image=debian-all-test-cross
+ container_cross_prefix=m68k-linux-gnu-
+ container_cross_cc=${container_cross_prefix}gcc
+ ;;
microblaze)
container_image=debian-microblaze-cross
container_cross_prefix=microblaze-linux-musl-
diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml
index 66b8844246..d42d89b26e 100644
--- a/.gitlab-ci.d/container-cross.yml
+++ b/.gitlab-ci.d/container-cross.yml
@@ -46,12 +46,6 @@ loongarch-debian-cross-container:
variables:
NAME: debian-loongarch-cross
-m68k-debian-cross-container:
- extends: .container_job_template
- stage: containers
- variables:
- NAME: debian-m68k-cross
-
mips64-debian-cross-container:
extends: .container_job_template
stage: containers
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 47e58a248e..fb93eca537 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -122,7 +122,7 @@ docker-image-debian-nios2-cross: $(DOCKER_FILES_DIR)/debian-toolchain.docker \
$(call debian-toolchain, $@)
# These images may be good enough for building tests but not for test builds
-DOCKER_PARTIAL_IMAGES += debian-m68k-cross debian-mips64-cross
+DOCKER_PARTIAL_IMAGES += debian-mips64-cross
DOCKER_PARTIAL_IMAGES += debian-microblaze-cross
DOCKER_PARTIAL_IMAGES += debian-mips-cross
DOCKER_PARTIAL_IMAGES += debian-nios2-cross
diff --git a/tests/docker/dockerfiles/debian-m68k-cross.docker b/tests/docker/dockerfiles/debian-m68k-cross.docker
deleted file mode 100644
index 25dd1c1e68..0000000000
--- a/tests/docker/dockerfiles/debian-m68k-cross.docker
+++ /dev/null
@@ -1,19 +0,0 @@
-#
-# Docker cross-compiler target
-#
-# This docker target builds on the Debian Bullseye base image.
-#
-FROM docker.io/library/debian:11-slim
-
-RUN export DEBIAN_FRONTEND=noninteractive && \
- apt-get update && \
- apt-get install -y eatmydata && \
- eatmydata apt-get dist-upgrade -y && \
- eatmydata apt-get install --no-install-recommends -y \
- gcc-m68k-linux-gnu \
- libc6-dev-m68k-cross
-# As a final step configure the user (if env is defined)
-ARG USER
-ARG UID
-RUN if [ "${USER}" ]; then \
- id ${USER} 2>/dev/null || useradd -u ${UID} -U ${USER}; fi
--
2.39.2
next prev parent reply other threads:[~2023-10-31 14:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 14:43 [PULL 00/19] Updates for testing, gitlab, gdbstub, plugins and semihosting Alex Bennée
2023-10-31 14:43 ` [PULL 01/19] tests/vm/openbsd: Use the system dtc package Alex Bennée
2023-10-31 14:43 ` [PULL 02/19] tests/tcg: Add -fno-stack-protector Alex Bennée
2023-10-31 14:43 ` [PULL 03/19] gitlab: split alpha testing into a legacy container Alex Bennée
2023-10-31 14:43 ` [PULL 04/19] gitlab: clean-up build-soft-softmmu job Alex Bennée
2023-10-31 14:43 ` [PULL 05/19] gitlab: add build-loongarch to matrix Alex Bennée
2023-10-31 14:43 ` [PULL 06/19] tests/docker: use debian-legacy-test-cross for alpha Alex Bennée
2023-10-31 14:43 ` [PULL 07/19] tests/docker: move sh4 to use debian-legacy-test-cross Alex Bennée
2023-10-31 14:43 ` [PULL 08/19] tests/docker: use debian-all-test-cross for power Alex Bennée
2023-10-31 14:43 ` [PULL 09/19] tests/docker: use debian-all-test-cross for hppa Alex Bennée
2023-10-31 14:43 ` Alex Bennée [this message]
2023-10-31 14:43 ` [PULL 11/19] tests/docker: use debian-all-test-cross for mips64 Alex Bennée
2023-10-31 14:43 ` [PULL 12/19] tests/docker: use debian-all-test-cross for mips Alex Bennée
2023-10-31 14:43 ` [PULL 13/19] tests/docker: use debian-all-test-cross for riscv64 Alex Bennée
2023-10-31 14:43 ` [PULL 14/19] tests/docker: use debian-all-test-cross for sparc64 Alex Bennée
2023-10-31 14:43 ` [PULL 15/19] tests/docker: upgrade debian-all-test-cross to bookworm Alex Bennée
2023-10-31 14:43 ` [PULL 16/19] gdbstub: Check if gdb_regs is NULL Alex Bennée
2023-10-31 14:43 ` [PULL 17/19] semihosting: fix memleak at semihosting_arg_fallback Alex Bennée
2023-10-31 14:44 ` [PULL 18/19] plugins: Remove an extra parameter Alex Bennée
2023-10-31 14:44 ` [PULL 19/19] contrib/plugins: Close file descriptor on error return Alex Bennée
2023-10-31 23:31 ` [PULL 00/19] Updates for testing, gitlab, gdbstub, plugins and semihosting Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031144401.1238210-11-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).