qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Cong Liu" <liucong2@kylinos.cn>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: [PULL 19/19] contrib/plugins: Close file descriptor on error return
Date: Tue, 31 Oct 2023 14:44:01 +0000	[thread overview]
Message-ID: <20231031144401.1238210-20-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231031144401.1238210-1-alex.bennee@linaro.org>

From: Cong Liu <liucong2@kylinos.cn>

This patch closes the file descriptor fd on error return to avoid
resource leak.

Fixes: ec7ee95db909 ("contrib/plugins: fix coverity warning in lockstep")
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Message-Id: <20231018025225.1640122-1-liucong2@kylinos.cn>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231029145033.592566-20-alex.bennee@linaro.org>

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index f0cb8792c6..237543b43a 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -257,6 +257,7 @@ static bool setup_socket(const char *path)
     sockaddr.sun_family = AF_UNIX;
     if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
         perror("bad path");
+        close(fd);
         return false;
     }
 
@@ -303,6 +304,7 @@ static bool connect_socket(const char *path)
     sockaddr.sun_family = AF_UNIX;
     if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
         perror("bad path");
+        close(fd);
         return false;
     }
 
-- 
2.39.2



  parent reply	other threads:[~2023-10-31 14:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 14:43 [PULL 00/19] Updates for testing, gitlab, gdbstub, plugins and semihosting Alex Bennée
2023-10-31 14:43 ` [PULL 01/19] tests/vm/openbsd: Use the system dtc package Alex Bennée
2023-10-31 14:43 ` [PULL 02/19] tests/tcg: Add -fno-stack-protector Alex Bennée
2023-10-31 14:43 ` [PULL 03/19] gitlab: split alpha testing into a legacy container Alex Bennée
2023-10-31 14:43 ` [PULL 04/19] gitlab: clean-up build-soft-softmmu job Alex Bennée
2023-10-31 14:43 ` [PULL 05/19] gitlab: add build-loongarch to matrix Alex Bennée
2023-10-31 14:43 ` [PULL 06/19] tests/docker: use debian-legacy-test-cross for alpha Alex Bennée
2023-10-31 14:43 ` [PULL 07/19] tests/docker: move sh4 to use debian-legacy-test-cross Alex Bennée
2023-10-31 14:43 ` [PULL 08/19] tests/docker: use debian-all-test-cross for power Alex Bennée
2023-10-31 14:43 ` [PULL 09/19] tests/docker: use debian-all-test-cross for hppa Alex Bennée
2023-10-31 14:43 ` [PULL 10/19] tests/docker: use debian-all-test-cross for m68k Alex Bennée
2023-10-31 14:43 ` [PULL 11/19] tests/docker: use debian-all-test-cross for mips64 Alex Bennée
2023-10-31 14:43 ` [PULL 12/19] tests/docker: use debian-all-test-cross for mips Alex Bennée
2023-10-31 14:43 ` [PULL 13/19] tests/docker: use debian-all-test-cross for riscv64 Alex Bennée
2023-10-31 14:43 ` [PULL 14/19] tests/docker: use debian-all-test-cross for sparc64 Alex Bennée
2023-10-31 14:43 ` [PULL 15/19] tests/docker: upgrade debian-all-test-cross to bookworm Alex Bennée
2023-10-31 14:43 ` [PULL 16/19] gdbstub: Check if gdb_regs is NULL Alex Bennée
2023-10-31 14:43 ` [PULL 17/19] semihosting: fix memleak at semihosting_arg_fallback Alex Bennée
2023-10-31 14:44 ` [PULL 18/19] plugins: Remove an extra parameter Alex Bennée
2023-10-31 14:44 ` Alex Bennée [this message]
2023-10-31 23:31 ` [PULL 00/19] Updates for testing, gitlab, gdbstub, plugins and semihosting Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231031144401.1238210-20-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=liucong2@kylinos.cn \
    --cc=ma.mandourr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).