qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
	qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, philmd@linaro.org,
	clg@kaod.org, imammedo@redhat.com, imp@bsdimp.com,
	kevans@freebsd.org, richard.henderson@linaro.org,
	pbonzini@redhat.com, peter.maydell@linaro.org,
	b.galvani@gmail.com, strahinja.p.jankovic@gmail.com,
	sundeep.lkml@gmail.com, kfting@nuvoton.com, wuhaotsh@google.com,
	nieklinnenbank@gmail.com, rad@semihalf.com,
	quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org,
	eduardo@habkost.net, marcel.apfelbaum@gmail.com,
	wangyanan55@huawei.com, laurent@vivier.eu, vijai@behindbytes.com,
	palmer@dabbelt.com, alistair.francis@wdc.com,
	bin.meng@windriver.com, liweiwei@iscas.ac.cn,
	dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
	mrolnik@gmail.com, edgar.iglesias@gmail.com, bcain@quicinc.com,
	gaosong@loongson.cn, aurelien@aurel32.net,
	jiaxun.yang@flygoat.com, aleksandar.rikalo@syrmia.com,
	chenhuacai@kernel.org, crwulff@gmail.com, marex@denx.de,
	shorne@gmail.com, npiggin@gmail.com, ysato@users.sourceforge.jp,
	david@redhat.com, thuth@redhat.com, iii@linux.ibm.com,
	kbastian@mail.uni-paderborn.de, jcmvbkbc@gmail.com,
	shan.gavin@gmail.com
Subject: [PATCH v4 31/33] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init()
Date: Thu,  2 Nov 2023 10:24:58 +1000	[thread overview]
Message-ID: <20231102002500.1750692-32-gshan@redhat.com> (raw)
In-Reply-To: <20231102002500.1750692-1-gshan@redhat.com>

Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.

Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 hw/arm/sbsa-ref.c | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index bce44690e5..64c321f627 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -144,27 +144,16 @@ static const int sbsa_ref_irqmap[] = {
     [SBSA_GWDT_WS0] = 16,
 };
 
-static const char * const valid_cpus[] = {
+static const char * const valid_cpu_types[] = {
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
     ARM_CPU_TYPE_NAME("neoverse-n1"),
     ARM_CPU_TYPE_NAME("neoverse-v1"),
     ARM_CPU_TYPE_NAME("neoverse-n2"),
     ARM_CPU_TYPE_NAME("max"),
+    NULL,
 };
 
-static bool cpu_type_valid(const char *cpu)
-{
-    int i;
-
-    for (i = 0; i < ARRAY_SIZE(valid_cpus); i++) {
-        if (strcmp(cpu, valid_cpus[i]) == 0) {
-            return true;
-        }
-    }
-    return false;
-}
-
 static uint64_t sbsa_ref_cpu_mp_affinity(SBSAMachineState *sms, int idx)
 {
     uint8_t clustersz = ARM_DEFAULT_CPUS_PER_CLUSTER;
@@ -730,11 +719,6 @@ static void sbsa_ref_init(MachineState *machine)
     const CPUArchIdList *possible_cpus;
     int n, sbsa_max_cpus;
 
-    if (!cpu_type_valid(machine->cpu_type)) {
-        error_report("sbsa-ref: CPU type %s not supported", machine->cpu_type);
-        exit(1);
-    }
-
     if (kvm_enabled()) {
         error_report("sbsa-ref: KVM is not supported for this machine");
         exit(1);
@@ -899,6 +883,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
     mc->init = sbsa_ref_init;
     mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
     mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
+    mc->valid_cpu_types = valid_cpu_types;
     mc->max_cpus = 512;
     mc->pci_allow_0_address = true;
     mc->minimum_page_bits = 12;
-- 
2.41.0



  parent reply	other threads:[~2023-11-02  0:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  0:24 [PATCH v4 00/33] Unified CPU type check Gavin Shan
2023-11-02  0:24 ` [PATCH v4 01/33] target/alpha: Tidy up alpha_cpu_class_by_name() Gavin Shan
2023-11-06 14:22   ` Igor Mammedov
2023-11-13 23:23     ` Gavin Shan
2023-11-02  0:24 ` [PATCH v4 02/33] hw/cpu: Call object_class_is_abstract() once in cpu_class_by_name() Gavin Shan
2023-11-06 14:40   ` Igor Mammedov
2023-11-13 23:46     ` Gavin Shan
2023-11-02  0:24 ` [PATCH v4 03/33] cpu: Call object_class_dynamic_cast() " Gavin Shan
2023-11-06 14:48   ` Igor Mammedov
2023-11-02  0:24 ` [PATCH v4 04/33] cpu: Add helper cpu_model_from_type() Gavin Shan
2023-11-02  0:24 ` [PATCH v4 05/33] target/alpha: Use generic helper to show CPU model names Gavin Shan
2023-11-02  0:24 ` [PATCH v4 06/33] target/arm: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 07/33] target/avr: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 08/33] target/cris: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 09/33] target/hexagon: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 10/33] target/i386: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 11/33] target/loongarch: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 12/33] target/m68k: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 13/33] target/mips: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 14/33] target/openrisc: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 15/33] target/ppc: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 16/33] target/riscv: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 17/33] target/rx: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 18/33] target/s390x: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 19/33] target/sh4: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 20/33] target/tricore: " Gavin Shan
2023-11-02  0:24 ` [PATCH v4 21/33] target/hppa: Implement hppa_cpu_list() Gavin Shan
2023-11-02  0:24 ` [PATCH v4 22/33] target/microblaze: Implement microblaze_cpu_list() Gavin Shan
2023-11-02  0:24 ` [PATCH v4 23/33] target/nios2: Implement nios2_cpu_list() Gavin Shan
2023-11-02  0:24 ` [PATCH v4 24/33] cpu: Mark cpu_list() supported on all targets Gavin Shan
2023-11-02  0:24 ` [PATCH v4 25/33] machine: Constify MachineClass::valid_cpu_types[i] Gavin Shan
2023-11-02  4:14   ` Richard Henderson
2023-11-02  0:24 ` [PATCH v4 26/33] machine: Use error handling when CPU type is checked Gavin Shan
2023-11-02  4:57   ` Richard Henderson
2023-11-02  0:24 ` [PATCH v4 27/33] machine: Introduce helper is_cpu_type_supported() Gavin Shan
2023-11-02  5:02   ` Richard Henderson
2023-11-02  0:24 ` [PATCH v4 28/33] machine: Print CPU model name instead of CPU type name Gavin Shan
2023-11-02  5:06   ` Richard Henderson
2023-11-02  0:24 ` [PATCH v4 29/33] hw/arm/virt: Check CPU type in machine_run_board_init() Gavin Shan
2023-11-02  5:09   ` Richard Henderson
2023-11-02  0:24 ` [PATCH v4 30/33] hw/arm/virt: Hide host CPU model for tcg Gavin Shan
2023-11-02  5:10   ` Richard Henderson
2023-11-02  0:24 ` Gavin Shan [this message]
2023-11-02  5:15   ` [PATCH v4 31/33] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init() Richard Henderson
2023-11-02  0:24 ` [PATCH v4 32/33] hw/arm: " Gavin Shan
2023-11-02  5:17   ` Richard Henderson
2023-11-02  0:25 ` [PATCH v4 33/33] hw/riscv/shakti_c: " Gavin Shan
2023-11-02  5:19   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102002500.1750692-32-gshan@redhat.com \
    --to=gshan@redhat.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alistair.francis@wdc.com \
    --cc=aurelien@aurel32.net \
    --cc=b.galvani@gmail.com \
    --cc=bcain@quicinc.com \
    --cc=bin.meng@windriver.com \
    --cc=chenhuacai@kernel.org \
    --cc=clg@kaod.org \
    --cc=crwulff@gmail.com \
    --cc=david@redhat.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=gaosong@loongson.cn \
    --cc=iii@linux.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kevans@freebsd.org \
    --cc=kfting@nuvoton.com \
    --cc=laurent@vivier.eu \
    --cc=liweiwei@iscas.ac.cn \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=marex@denx.de \
    --cc=mrolnik@gmail.com \
    --cc=nieklinnenbank@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=rad@semihalf.com \
    --cc=richard.henderson@linaro.org \
    --cc=shan.gavin@gmail.com \
    --cc=shorne@gmail.com \
    --cc=strahinja.p.jankovic@gmail.com \
    --cc=sundeep.lkml@gmail.com \
    --cc=thuth@redhat.com \
    --cc=vijai@behindbytes.com \
    --cc=wangyanan55@huawei.com \
    --cc=wuhaotsh@google.com \
    --cc=ysato@users.sourceforge.jp \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).