* [PATCH] build-sys: fix meson project version usage
@ 2023-11-02 14:10 marcandre.lureau
2023-11-10 8:05 ` Marc-André Lureau
2023-11-25 17:15 ` Konstantin Kostiuk
0 siblings, 2 replies; 4+ messages in thread
From: marcandre.lureau @ 2023-11-02 14:10 UTC (permalink / raw)
To: qemu-devel
Cc: pbonzini, Marc-André Lureau, Michael Roth,
Konstantin Kostiuk
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Program wixl found: YES (/usr/bin/wixl)
../qga/meson.build:149:16: ERROR: Unknown variable "project".
Fixes: e20d68aa0b9 ("configure, meson: use command line options to configure qemu-ga")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
qga/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/meson.build b/qga/meson.build
index 940a51d55d..ff7a8496e4 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -146,7 +146,7 @@ if targetos == 'windows'
libpcre = 'libpcre2'
endif
qga_msi_version = get_option('qemu_ga_version') == '' \
- ? project.version() \
+ ? meson.project_version() \
: get_option('qemu_ga_version')
qga_msi = custom_target('QGA MSI',
input: files('installer/qemu-ga.wxs'),
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] build-sys: fix meson project version usage
2023-11-02 14:10 [PATCH] build-sys: fix meson project version usage marcandre.lureau
@ 2023-11-10 8:05 ` Marc-André Lureau
2023-11-25 17:15 ` Konstantin Kostiuk
1 sibling, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2023-11-10 8:05 UTC (permalink / raw)
To: qemu-devel, pbonzini; +Cc: Michael Roth, Konstantin Kostiuk
On Thu, Nov 2, 2023 at 6:11 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Program wixl found: YES (/usr/bin/wixl)
>
> ../qga/meson.build:149:16: ERROR: Unknown variable "project".
>
> Fixes: e20d68aa0b9 ("configure, meson: use command line options to configure qemu-ga")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
ping
> ---
> qga/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/meson.build b/qga/meson.build
> index 940a51d55d..ff7a8496e4 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -146,7 +146,7 @@ if targetos == 'windows'
> libpcre = 'libpcre2'
> endif
> qga_msi_version = get_option('qemu_ga_version') == '' \
> - ? project.version() \
> + ? meson.project_version() \
> : get_option('qemu_ga_version')
> qga_msi = custom_target('QGA MSI',
> input: files('installer/qemu-ga.wxs'),
> --
> 2.41.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build-sys: fix meson project version usage
2023-11-02 14:10 [PATCH] build-sys: fix meson project version usage marcandre.lureau
2023-11-10 8:05 ` Marc-André Lureau
@ 2023-11-25 17:15 ` Konstantin Kostiuk
2023-11-25 17:35 ` Konstantin Kostiuk
1 sibling, 1 reply; 4+ messages in thread
From: Konstantin Kostiuk @ 2023-11-25 17:15 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, pbonzini, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Thu, Nov 2, 2023 at 4:10 PM <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Program wixl found: YES (/usr/bin/wixl)
>
> ../qga/meson.build:149:16: ERROR: Unknown variable "project".
>
> Fixes: e20d68aa0b9 ("configure, meson: use command line options to
> configure qemu-ga")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/meson.build b/qga/meson.build
> index 940a51d55d..ff7a8496e4 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -146,7 +146,7 @@ if targetos == 'windows'
> libpcre = 'libpcre2'
> endif
> qga_msi_version = get_option('qemu_ga_version') == '' \
> - ? project.version() \
> + ? meson.project_version() \
> : get_option('qemu_ga_version')
> qga_msi = custom_target('QGA MSI',
> input: files('installer/qemu-ga.wxs'),
> --
> 2.41.0
>
>
[-- Attachment #2: Type: text/html, Size: 1756 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build-sys: fix meson project version usage
2023-11-25 17:15 ` Konstantin Kostiuk
@ 2023-11-25 17:35 ` Konstantin Kostiuk
0 siblings, 0 replies; 4+ messages in thread
From: Konstantin Kostiuk @ 2023-11-25 17:35 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, pbonzini, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
PULL sent
https://patchew.org/QEMU/20231125173011.374840-1-kkostiuk@redhat.com/
On Sat, Nov 25, 2023 at 7:15 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>
> On Thu, Nov 2, 2023 at 4:10 PM <marcandre.lureau@redhat.com> wrote:
>
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Program wixl found: YES (/usr/bin/wixl)
>>
>> ../qga/meson.build:149:16: ERROR: Unknown variable "project".
>>
>> Fixes: e20d68aa0b9 ("configure, meson: use command line options to
>> configure qemu-ga")
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> qga/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qga/meson.build b/qga/meson.build
>> index 940a51d55d..ff7a8496e4 100644
>> --- a/qga/meson.build
>> +++ b/qga/meson.build
>> @@ -146,7 +146,7 @@ if targetos == 'windows'
>> libpcre = 'libpcre2'
>> endif
>> qga_msi_version = get_option('qemu_ga_version') == '' \
>> - ? project.version() \
>> + ? meson.project_version() \
>> : get_option('qemu_ga_version')
>> qga_msi = custom_target('QGA MSI',
>> input: files('installer/qemu-ga.wxs'),
>> --
>> 2.41.0
>>
>>
[-- Attachment #2: Type: text/html, Size: 2299 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-25 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02 14:10 [PATCH] build-sys: fix meson project version usage marcandre.lureau
2023-11-10 8:05 ` Marc-André Lureau
2023-11-25 17:15 ` Konstantin Kostiuk
2023-11-25 17:35 ` Konstantin Kostiuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).