From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support
Date: Fri, 3 Nov 2023 09:41:39 +0100 [thread overview]
Message-ID: <20231103-d807055c7e1eb53d8f8eb1b7@orel> (raw)
In-Reply-To: <20231102224445.527355-11-dbarboza@ventanamicro.com>
On Thu, Nov 02, 2023 at 07:44:36PM -0300, Daniel Henrique Barboza wrote:
...
> + if (profile->enabled) {
> + /*
> + * Note: the 'priv_spec' command line option, if present,
> + * will take precedence over this priv_ver bump.
> + */
> + cpu_validate_multi_ext_priv_ver(&cpu->env, ext_offset);
> + }
If we moved the comment into cpu_validate_multi_ext_priv_ver() we wouldn't
need it's third occurrence to be added here.
Thanks,
drew
next prev parent reply other threads:[~2023-11-03 8:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 22:44 [PATCH v9 00/19] rv64i and rva22u64 CPUs, RVA22U64 profile support Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 01/19] target/riscv: create TYPE_RISCV_VENDOR_CPU Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 02/19] target/riscv/tcg: do not use "!generic" CPU checks Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 03/19] target/riscv/tcg: update priv_ver on user_set extensions Daniel Henrique Barboza
2023-11-03 8:33 ` Andrew Jones
2023-11-03 11:34 ` Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 04/19] target/riscv: add rv64i CPU Daniel Henrique Barboza
2023-11-03 8:37 ` Andrew Jones
2023-11-02 22:44 ` [PATCH v9 05/19] target/riscv: add zicbop extension flag Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 06/19] target/riscv/tcg: add 'zic64b' support Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 07/19] riscv-qmp-cmds.c: expose named features in cpu_model_expansion Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 08/19] target/riscv: add rva22u64 profile definition Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 09/19] target/riscv/kvm: add 'rva22u64' flag as unavailable Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support Daniel Henrique Barboza
2023-11-03 8:41 ` Andrew Jones [this message]
2023-11-02 22:44 ` [PATCH v9 11/19] target/riscv/tcg: add MISA user options hash Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 12/19] target/riscv/tcg: add riscv_cpu_write_misa_bit() Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 13/19] target/riscv/tcg: handle profile MISA bits Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 14/19] target/riscv/tcg: add hash table insert helpers Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 15/19] target/riscv/tcg: honor user choice for G MISA bits Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 16/19] target/riscv/tcg: validate profiles during finalize Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 17/19] riscv-qmp-cmds.c: add profile flags in cpu-model-expansion Daniel Henrique Barboza
2023-11-02 22:44 ` [PATCH v9 18/19] target/riscv: add 'rva22u64' CPU Daniel Henrique Barboza
2023-11-03 8:50 ` Andrew Jones
2023-11-02 22:44 ` [PATCH v9 19/19] target/riscv/tcg: do not support profiles for 'max' CPU Daniel Henrique Barboza
2023-11-03 9:01 ` Andrew Jones
2023-11-03 11:13 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103-d807055c7e1eb53d8f8eb1b7@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).