From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B361EC4332F for ; Fri, 3 Nov 2023 08:42:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qypkQ-00062y-4S; Fri, 03 Nov 2023 04:41:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qypkO-00062b-2b for qemu-devel@nongnu.org; Fri, 03 Nov 2023 04:41:44 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qypkM-0007uJ-AZ for qemu-devel@nongnu.org; Fri, 03 Nov 2023 04:41:43 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo2871867a12.3 for ; Fri, 03 Nov 2023 01:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1699000900; x=1699605700; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=riLFcfPYNOzTfgJPY9RgePEkUL5HjPL0i0qIsZBP5FI=; b=M3s0UvumiKDnDf20wzAMtvM5ccf3aC3LqyRJ/LJm4nm6srNBj57yM/apBg1nFOtG7o ptPzQx93tiN+qZLu4J9eqKoxYJUyqj6pDtKVPdqAzAFG0iUcUE/j0J9u8+Snbx/U0B3q BRini/2zcWik/VRIf/Y2LuD6rO27zxNqVzO6lEVjc5KrOcdsb0k8Rzc/JYN11qjRMs5L fuihOO7ikoX49q/llWlMNXlckILzcRwuh9pJ2+mc97PqGyD6kP3xn6ZAwNmhZsiaU1Ke ZtEjxHY9wRv+/rKxkGvPDebvoVSWLJe7xQchYbyfNSxvxfVa3ZDKUYtYUtVdcREE5BoC cEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699000900; x=1699605700; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=riLFcfPYNOzTfgJPY9RgePEkUL5HjPL0i0qIsZBP5FI=; b=ZL8UZ3bgcQR4J6+M5FA1L2MIY2PCXQSmcLbrg7Y87Zg09MGisJ2rbgImn11jmWohBD Y3SgzFtWb4N4g6uXCJ20ByVMglmX1G/rszsDGOwlIFU055fxVFVfVbHukDt7S+fgayy7 mm8ALw1x0kY3f2WYCd48mF3jjfhdJY+m0xPp+mrua7wBrW5/1yuFlj7SdfmxsvJWBGJc 735bPLP4iDMwUKxiQNqRzdnWXnX2aXJXrhKDYje3hzLHqMTEBfSv/nU5FwKd7iDnMTqx HPUYyoeYqal8+riycMOFEHdwbs+Wfe97+RILsAcrn2voevKfI8V8xPMjQfJiOCipCZjA GEPw== X-Gm-Message-State: AOJu0Ywxus6eGNYm9nHNdVJPDph8KGTVmE7dfuEjtFhRIZSYNX0R5zMY P7a9vi9WuF6CJtaSNBZS0qwX3g== X-Google-Smtp-Source: AGHT+IGz0PsyFVKqvhkCvJ44qYkEQVOF7na/g5YDb/eTRIfOcFo6/IAp7IAG8nBQ82Ncvv+HUBypMA== X-Received: by 2002:aa7:de15:0:b0:53d:eca9:742e with SMTP id h21-20020aa7de15000000b0053deca9742emr19169021edv.9.1699000900457; Fri, 03 Nov 2023 01:41:40 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id b17-20020aa7d491000000b0053443c8fd90sm695383edr.24.2023.11.03.01.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 01:41:40 -0700 (PDT) Date: Fri, 3 Nov 2023 09:41:39 +0100 From: Andrew Jones To: Daniel Henrique Barboza Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com Subject: Re: [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support Message-ID: <20231103-d807055c7e1eb53d8f8eb1b7@orel> References: <20231102224445.527355-1-dbarboza@ventanamicro.com> <20231102224445.527355-11-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102224445.527355-11-dbarboza@ventanamicro.com> Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=ajones@ventanamicro.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Nov 02, 2023 at 07:44:36PM -0300, Daniel Henrique Barboza wrote: ... > + if (profile->enabled) { > + /* > + * Note: the 'priv_spec' command line option, if present, > + * will take precedence over this priv_ver bump. > + */ > + cpu_validate_multi_ext_priv_ver(&cpu->env, ext_offset); > + } If we moved the comment into cpu_validate_multi_ext_priv_ver() we wouldn't need it's third occurrence to be added here. Thanks, drew