qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Michael Tokarev <mjt@tls.msk.ru>,
	Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v2 0/5] target/s390x: CC fixes
Date: Mon,  6 Nov 2023 10:31:21 +0100	[thread overview]
Message-ID: <20231106093605.1349201-1-iii@linux.ibm.com> (raw)

v1: https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg10251.html
v1 -> v2: Introduce op_laa_addu64() (Richard).
          Add the ADD LOGICAL WITH CARRY test. This was intended to
          catch the issue mentioned by David, but did not succeed. I
          thought it would still be worthwile to include it as a
          regression test.

Hi,

This series fixes two issues with updating CC. David was suggesting a
bigger rewrite [1], but I did not dare do this (yet). Instead, these
are targeted fixes: patch 1 helps with installing Fedora, and patch 3
addresses something I noticed when reviewing the code. Patches 2, 4 and
5 are tests.

Best regards,
Ilya

[1] https://gitlab.com/qemu-project/qemu/-/issues/1865#note_1545060658

Ilya Leoshkevich (5):
  target/s390x: Fix CLC corrupting cc_src
  tests/tcg/s390x: Test CLC with inaccessible second operand
  target/s390x: Fix LAALG not updating cc_src
  tests/tcg/s390x: Test LAALG with negative cc_src
  tests/tcg/s390x: Test ADD LOGICAL WITH CARRY

 target/s390x/tcg/insn-data.h.inc         |   2 +-
 target/s390x/tcg/translate.c             |  26 +++-
 tests/tcg/s390x/Makefile.target          |   3 +
 tests/tcg/s390x/add-logical-with-carry.c | 156 +++++++++++++++++++++++
 tests/tcg/s390x/clc.c                    |  48 +++++++
 tests/tcg/s390x/laalg.c                  |  27 ++++
 6 files changed, 257 insertions(+), 5 deletions(-)
 create mode 100644 tests/tcg/s390x/add-logical-with-carry.c
 create mode 100644 tests/tcg/s390x/clc.c
 create mode 100644 tests/tcg/s390x/laalg.c

-- 
2.41.0



             reply	other threads:[~2023-11-06  9:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  9:31 Ilya Leoshkevich [this message]
2023-11-06  9:31 ` [PATCH v2 1/5] target/s390x: Fix CLC corrupting cc_src Ilya Leoshkevich
2023-11-06 20:17   ` David Hildenbrand
2023-11-06  9:31 ` [PATCH v2 2/5] tests/tcg/s390x: Test CLC with inaccessible second operand Ilya Leoshkevich
2023-11-06 16:12   ` Richard Henderson
2023-11-06  9:31 ` [PATCH v2 3/5] target/s390x: Fix LAALG not updating cc_src Ilya Leoshkevich
2023-11-06 16:14   ` Richard Henderson
2023-11-06 20:18   ` David Hildenbrand
2023-11-06  9:31 ` [PATCH v2 4/5] tests/tcg/s390x: Test LAALG with negative cc_src Ilya Leoshkevich
2023-11-06 16:15   ` Richard Henderson
2023-11-06  9:31 ` [PATCH v2 5/5] tests/tcg/s390x: Test ADD LOGICAL WITH CARRY Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231106093605.1349201-1-iii@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).