From: David Woodhouse <dwmw2@infradead.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Hao Wu" <wuhaotsh@google.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Helge Deller" <deller@gmx.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Song Gao" <gaosong@loongson.cn>,
"Thomas Huth" <huth@tuxfamily.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Jason Wang" <jasowang@redhat.com>, "Jia Liu" <proljc@gmail.com>,
"Stafford Horne" <shorne@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Weiwei Li" <liweiwei@iscas.ac.cn>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paul Durrant" <paul@xen.org>,
"Max Filippov" <jcmvbkbc@gmail.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org
Subject: [PATCH for-8.3 v2 41/46] hw/sparc/sun4m: use qemu_find_nic_info()
Date: Mon, 6 Nov 2023 19:49:46 +0000 [thread overview]
Message-ID: <20231106195352.301038-42-dwmw2@infradead.org> (raw)
In-Reply-To: <20231106195352.301038-1-dwmw2@infradead.org>
From: David Woodhouse <dwmw@amazon.co.uk>
Obtain the MAC address from the NIC configuration if there is one, or
generate one explicitly so that it can be placed in the PROM.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
hw/sparc/sun4m.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 17bf5f2879..75b0c0ff7a 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -299,13 +299,15 @@ static void *iommu_init(hwaddr addr, uint32_t version, qemu_irq irq)
static void *sparc32_dma_init(hwaddr dma_base,
hwaddr esp_base, qemu_irq espdma_irq,
- hwaddr le_base, qemu_irq ledma_irq, NICInfo *nd)
+ hwaddr le_base, qemu_irq ledma_irq,
+ MACAddr *mac)
{
DeviceState *dma;
ESPDMADeviceState *espdma;
LEDMADeviceState *ledma;
SysBusESPState *esp;
SysBusPCNetState *lance;
+ NICInfo *nd = qemu_find_nic_info("lance", true, NULL);
dma = qdev_new(TYPE_SPARC32_DMA);
espdma = SPARC32_ESPDMA_DEVICE(object_resolve_path_component(
@@ -320,7 +322,14 @@ static void *sparc32_dma_init(hwaddr dma_base,
lance = SYSBUS_PCNET(object_resolve_path_component(
OBJECT(ledma), "lance"));
- qdev_set_nic_properties(DEVICE(lance), nd);
+
+ if (nd) {
+ qdev_set_nic_properties(DEVICE(lance), nd);
+ memcpy(mac->a, nd->macaddr.a, sizeof(mac->a));
+ } else {
+ qemu_macaddr_default_if_unset(mac);
+ qdev_prop_set_macaddr(DEVICE(lance), "mac", mac->a);
+ }
sysbus_realize_and_unref(SYS_BUS_DEVICE(dma), &error_fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(dma), 0, dma_base);
@@ -832,7 +841,7 @@ static void sun4m_hw_init(MachineState *machine)
unsigned int smp_cpus = machine->smp.cpus;
unsigned int max_cpus = machine->smp.max_cpus;
HostMemoryBackend *ram_memdev = machine->memdev;
- NICInfo *nd = &nd_table[0];
+ MACAddr hostid;
if (machine->ram_size > hwdef->max_mem) {
error_report("Too much memory for this machine: %" PRId64 ","
@@ -893,10 +902,9 @@ static void sun4m_hw_init(MachineState *machine)
hwdef->iommu_pad_base, hwdef->iommu_pad_len);
}
- qemu_check_nic_model(nd, TYPE_LANCE);
sparc32_dma_init(hwdef->dma_base,
hwdef->esp_base, slavio_irq[18],
- hwdef->le_base, slavio_irq[16], nd);
+ hwdef->le_base, slavio_irq[16], &hostid);
if (graphic_depth != 8 && graphic_depth != 24) {
error_report("Unsupported depth: %d", graphic_depth);
@@ -1048,7 +1056,7 @@ static void sun4m_hw_init(MachineState *machine)
machine->initrd_filename,
machine->ram_size, &initrd_size);
- nvram_init(nvram, (uint8_t *)&nd->macaddr, machine->kernel_cmdline,
+ nvram_init(nvram, hostid.a, machine->kernel_cmdline,
machine->boot_config.order, machine->ram_size, kernel_size,
graphic_width, graphic_height, graphic_depth,
hwdef->nvram_machine_id, "Sun4m");
--
2.41.0
next prev parent reply other threads:[~2023-11-06 19:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:49 [PATCH for-8.3 v2 00/46] Rework matching of network devices to -nic options David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 02/46] net: report list of available models according to platform David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 03/46] net: add qemu_create_nic_bus_devices() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 04/46] hw/pci: add pci_init_nic_devices(), pci_init_nic_in_slot() David Woodhouse
2023-11-10 7:31 ` Philippe Mathieu-Daudé
2023-11-10 9:21 ` David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices() David Woodhouse
2023-11-10 7:40 ` Philippe Mathieu-Daudé
2023-11-10 9:27 ` David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 06/46] hw/xen: use qemu_create_nic_bus_devices() to instantiate Xen NICs David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 07/46] hw/alpha/dp264: use pci_init_nic_devices() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 08/46] hw/arm/sbsa-ref: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 09/46] hw/arm/virt: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 10/46] hw/hppa: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 11/46] hw/loongarch: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 12/46] hw/mips/fuloong2e: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 13/46] hw/mips/malta: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 14/46] hw/mips/loongson3_virt: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 15/46] hw/ppc/prep: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 16/46] hw/ppc/spapr: use qemu_get_nic_info() and pci_init_nic_devices() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 17/46] hw/ppc: use pci_init_nic_devices() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 18/46] hw/sh4/r2d: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 19/46] hw/sparc64/sun4u: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 20/46] hw/xtensa/virt: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 21/46] hw/arm/allwinner: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 22/46] hw/arm/aspeed: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 23/46] hw/arm/exynos4: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 24/46] hw/arm/fsl: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 25/46] hw/net/smc91c111: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 26/46] hw/net/lan9118: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 27/46] hw/arm/highbank: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 28/46] hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 29/46] hw/arm/stellaris: use qemu_find_nic_info() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 30/46] hw/arm: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 31/46] hw/net/etraxfs-eth: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 32/46] hw/m68k/mcf5208: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 33/46] hw/m68k/q800: use qemu_find_nic_info() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 34/46] hw/microblaze: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 35/46] hw/mips/mipssim: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 36/46] hw/mips/jazz: use qemu_find_nic_info() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 37/46] hw/net/lasi_i82596: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 38/46] hw/openrisc/openrisc_sim: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 39/46] hw/riscv: use qemu_configure_nic_device() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device() David Woodhouse
2023-11-06 19:49 ` David Woodhouse [this message]
2023-11-06 19:49 ` [PATCH for-8.3 v2 42/46] hw/xtensa/xtfpga: " David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 43/46] net: remove qemu_check_nic_model() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 44/46] hw/pci: remove pci_nic_init_nofail() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 45/46] net: remove qemu_show_nic_models(), qemu_find_nic_model() David Woodhouse
2023-11-06 19:49 ` [PATCH for-8.3 v2 46/46] net: make nb_nics and nd_table[] static in net/net.c David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106195352.301038-42-dwmw2@infradead.org \
--to=dwmw2@infradead.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alistair@alistair23.me \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=anthony.perard@citrix.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=bin.meng@windriver.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=gaosong@loongson.cn \
--cc=harshpb@linux.ibm.com \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=i.mitsyanko@gmail.com \
--cc=iii@linux.ibm.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=laurent@vivier.eu \
--cc=liweiwei@iscas.ac.cn \
--cc=magnus.damm@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=nieklinnenbank@gmail.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=robh@kernel.org \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sundeep.lkml@gmail.com \
--cc=wuhaotsh@google.com \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).