From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
virtio-fs@redhat.com, "Hanna Reitz" <hreitz@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Erik Schilling" <erik.schilling@linaro.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base
Date: Tue, 7 Nov 2023 03:54:07 -0500 [thread overview]
Message-ID: <20231107035245-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20231106191515.2801863-4-alex.bennee@linaro.org>
On Mon, Nov 06, 2023 at 07:15:12PM +0000, Alex Bennée wrote:
> - case CHR_EVENT_CLOSED:
> - /* defer close until later to avoid circular close */
> - vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev,
> - vu_gpio_disconnect, vu_gpio_event);
I don't remember what is the circular close but I'd be much
calmer if this refactoring also didn't change behaviour.
Or if it does, please document why it's safe in the commit log.
--
MST
next prev parent reply other threads:[~2023-11-07 8:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:15 [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p Alex Bennée
2023-11-06 19:15 ` [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device Alex Bennée
2023-11-07 7:15 ` Michael S. Tsirkin
2023-11-07 16:06 ` Alex Bennée
2023-11-07 7:34 ` Michael S. Tsirkin
2023-11-07 8:03 ` Alex Bennée
2023-11-07 8:06 ` Michael S. Tsirkin
2023-11-06 19:15 ` [PATCH v6 2/6] hw/virtio: derive vhost-user-rng from vhost-user-base Alex Bennée
2023-11-06 19:15 ` [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio " Alex Bennée
2023-11-07 8:54 ` Michael S. Tsirkin [this message]
2023-11-06 19:15 ` [PATCH v6 4/6] hw/virtio: derive vhost-user-i2c " Alex Bennée
2023-11-06 19:15 ` [PATCH v6 5/6] hw/virtio: add vhost-user-snd and virtio-snd-pci devices Alex Bennée
2023-11-06 19:15 ` [PATCH v6 6/6] docs/system: add a basic enumeration of vhost-user devices Alex Bennée
2023-11-07 8:09 ` [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p Mark Cave-Ayland
2023-11-07 8:37 ` Michael S. Tsirkin
2023-11-07 8:46 ` Michael S. Tsirkin
2023-11-07 9:53 ` Michael S. Tsirkin
2023-11-07 18:18 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107035245-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=erik.schilling@linaro.org \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mathieu.poirier@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).