From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC67FC4332F for ; Tue, 7 Nov 2023 08:54:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0Hqp-0005XZ-JX; Tue, 07 Nov 2023 03:54:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Hqo-0005XQ-Nz for qemu-devel@nongnu.org; Tue, 07 Nov 2023 03:54:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Hqn-0003tK-BD for qemu-devel@nongnu.org; Tue, 07 Nov 2023 03:54:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699347260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o0cZ+ZhR2DJ2yBaYHFqcJusx27YTGlIT36Q55ajXsb8=; b=P5VY/qAOJ6cK9+jUKrGbRhqWl/qsZjy19FJvX2OKSFBs5tHgAWGeIMfo6dsn2E5jFN58HS AZbkwZ7vK/IIh991VT5CQEoZNiG1WLRub4dyPEU9cZaUwjCXeyd36ki3K52b3Ka4O3mtIa fpmLpYFIXK4JOjjwcHsnt5Zxhzh7ZbQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-4gfOXRZlMPmIhUkbjzoAng-1; Tue, 07 Nov 2023 03:54:19 -0500 X-MC-Unique: 4gfOXRZlMPmIhUkbjzoAng-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4084163ecd9so35596185e9.3 for ; Tue, 07 Nov 2023 00:54:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699347258; x=1699952058; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o0cZ+ZhR2DJ2yBaYHFqcJusx27YTGlIT36Q55ajXsb8=; b=tkkX9BHE0cEirzhEb5nZjRYGOM6HtoUZGb4gmEv0gdhJFbFq3ymE5phHf41jyDQDH9 68l6Qd3CCgzGIaTxtsMi6mZlSmfWzElqb2haxhHB9cWiKYY/XERldBt4OTisuTmP0eHI ExEP8M2LheRYMX7QGdN22Ws6d9dnVarVpxoeuy05gXsSyNWopVAdXWtaVsU2h8hHFf8o G0D5lAWLBPm8mqg8WraHFYBg2KbGiXgpZSa0R7h8bEBdijgCwYlSNtMmDmuok8Y2vGlO k6IdLIjgI/INmnEd+d6wifDZL1/JV7SGrV7GWMVQHhYH3FBdbSL5z5YhLkduywZ4SNdl tW1Q== X-Gm-Message-State: AOJu0YwJ1O4WK3hF26Zj9UqnbyP5B/IkOaPnqV9U3MP1LM3hD71Rgf7J bbF+VjL6f1aIg6LlxrrJLdBT2nEqnOPt4aEJaxn0DQcx1TkGArsbkooKAfZqM9NWb/OWfAiCUlQ uUsIK33ziGD4U7ck= X-Received: by 2002:a05:600c:470d:b0:408:5919:5f97 with SMTP id v13-20020a05600c470d00b0040859195f97mr1767599wmo.25.1699347257946; Tue, 07 Nov 2023 00:54:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFW0DP4MVyvdDuQGAZ/B1lFN6dxwRGcUlEsS2knpZNuWx+hxrZ38TehffriqfgJX5UnNL3CYA== X-Received: by 2002:a05:600c:470d:b0:408:5919:5f97 with SMTP id v13-20020a05600c470d00b0040859195f97mr1767586wmo.25.1699347257554; Tue, 07 Nov 2023 00:54:17 -0800 (PST) Received: from redhat.com ([2.55.5.143]) by smtp.gmail.com with ESMTPSA id fm15-20020a05600c0c0f00b00405391f485fsm15230888wmb.41.2023.11.07.00.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 00:54:16 -0800 (PST) Date: Tue, 7 Nov 2023 03:54:07 -0500 From: "Michael S. Tsirkin" To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org, Jason Wang , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-block@nongnu.org, Markus Armbruster , Mark Cave-Ayland , Stefan Hajnoczi , Gerd Hoffmann , "Gonglei (Arei)" , virtio-fs@redhat.com, Hanna Reitz , Fam Zheng , Raphael Norwitz , Kevin Wolf , Erik Schilling , Viresh Kumar , Mathieu Poirier , Eric Blake , Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Eduardo Habkost Subject: Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base Message-ID: <20231107035245-mutt-send-email-mst@kernel.org> References: <20231106191515.2801863-1-alex.bennee@linaro.org> <20231106191515.2801863-4-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231106191515.2801863-4-alex.bennee@linaro.org> Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Nov 06, 2023 at 07:15:12PM +0000, Alex Bennée wrote: > - case CHR_EVENT_CLOSED: > - /* defer close until later to avoid circular close */ > - vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev, > - vu_gpio_disconnect, vu_gpio_event); I don't remember what is the circular close but I'd be much calmer if this refactoring also didn't change behaviour. Or if it does, please document why it's safe in the commit log. -- MST