From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	marcandre.lureau@redhat.com,  thuth@redhat.com
Subject: Re: [PATCH 2/4] target/s390x/dump: Remove unneeded dump info function pointer init
Date: Tue, 7 Nov 2023 18:12:42 +0100	[thread overview]
Message-ID: <20231107181242.05f20439@p-imbrenda> (raw)
In-Reply-To: <20231107142048.22422-3-frankja@linux.ibm.com>
On Tue,  7 Nov 2023 14:20:46 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> dump_state_prepare() now sets the fucntion pointers to NULL so we only
> need to touch them if we're going to use them.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
I would merge this and the previous patch
> ---
>  target/s390x/arch_dump.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c
> index 51a2116515..bdb0bfa0e7 100644
> --- a/target/s390x/arch_dump.c
> +++ b/target/s390x/arch_dump.c
> @@ -448,10 +448,6 @@ int cpu_get_dump_info(ArchDumpInfo *info,
>          info->arch_sections_add_fn = *arch_sections_add;
>          info->arch_sections_write_hdr_fn = *arch_sections_write_hdr;
>          info->arch_sections_write_fn = *arch_sections_write;
> -    } else {
> -        info->arch_sections_add_fn = NULL;
> -        info->arch_sections_write_hdr_fn = NULL;
> -        info->arch_sections_write_fn = NULL;
>      }
>      return 0;
>  }
next prev parent reply	other threads:[~2023-11-07 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 14:20 [PATCH 0/4] dump: Arch info function pointer addition and cleanup Janosch Frank
2023-11-07 14:20 ` [PATCH 1/4] dump: Set dump info function pointers to NULL Janosch Frank
2023-11-08  8:03   ` Marc-André Lureau
2023-11-08  8:58     ` Janosch Frank
2023-11-07 14:20 ` [PATCH 2/4] target/s390x/dump: Remove unneeded dump info function pointer init Janosch Frank
2023-11-07 17:12   ` Claudio Imbrenda [this message]
2023-11-08  8:09   ` Marc-André Lureau
2023-11-07 14:20 ` [PATCH 3/4] dump: Add arch cleanup function Janosch Frank
2023-11-07 14:20 ` [PATCH 4/4] target/s390x/arch_dump: Add arch cleanup function for PV dumps Janosch Frank
2023-11-08  8:17   ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20231107181242.05f20439@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).