qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, marcandre.lureau@redhat.com,
	thuth@redhat.com, imbrenda@linux.ibm.com
Subject: [PATCH v2 1/3] target/s390x/dump: Remove unneeded dump info function pointer init
Date: Thu,  9 Nov 2023 12:04:41 +0000	[thread overview]
Message-ID: <20231109120443.185979-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20231109120443.185979-1-frankja@linux.ibm.com>

dump_state_prepare() now sets the function pointers to NULL so we only
need to touch them if we're going to use them.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 target/s390x/arch_dump.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c
index 51a2116515..bdb0bfa0e7 100644
--- a/target/s390x/arch_dump.c
+++ b/target/s390x/arch_dump.c
@@ -448,10 +448,6 @@ int cpu_get_dump_info(ArchDumpInfo *info,
         info->arch_sections_add_fn = *arch_sections_add;
         info->arch_sections_write_hdr_fn = *arch_sections_write_hdr;
         info->arch_sections_write_fn = *arch_sections_write;
-    } else {
-        info->arch_sections_add_fn = NULL;
-        info->arch_sections_write_hdr_fn = NULL;
-        info->arch_sections_write_fn = NULL;
     }
     return 0;
 }
-- 
2.34.1



  reply	other threads:[~2023-11-09 12:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 12:04 [PATCH v2 0/3] dump: Arch info function pointer addition and cleanup Janosch Frank
2023-11-09 12:04 ` Janosch Frank [this message]
2023-11-09 13:14   ` [PATCH v2 1/3] target/s390x/dump: Remove unneeded dump info function pointer init Thomas Huth
2023-11-09 12:04 ` [PATCH v2 2/3] dump: Add arch cleanup function Janosch Frank
2023-11-09 13:15   ` Thomas Huth
2023-11-09 12:04 ` [PATCH v2 3/3] target/s390x/arch_dump: Add arch cleanup function for PV dumps Janosch Frank
2023-11-09 12:24   ` Claudio Imbrenda
2023-11-09 13:18   ` Thomas Huth
2023-11-10 13:35 ` [PATCH v2 0/3] dump: Arch info function pointer addition and cleanup Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109120443.185979-2-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).