qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bui Quang Minh <minhquangbui99@gmail.com>
To: qemu-devel@nongnu.org
Cc: "David Woodhouse" <dwmw2@infradead.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Phil Dennis-Jordan" <lists@philjordan.eu>,
	"Santosh Shukla" <santosh.shukla@amd.com>,
	"Bui Quang Minh" <minhquangbui99@gmail.com>
Subject: [PATCH v10 4/7] intel_iommu: allow Extended Interrupt Mode when using userspace APIC
Date: Thu,  9 Nov 2023 22:19:21 +0700	[thread overview]
Message-ID: <20231109151924.267515-5-minhquangbui99@gmail.com> (raw)
In-Reply-To: <20231109151924.267515-1-minhquangbui99@gmail.com>

As userspace APIC now supports x2APIC, intel interrupt remapping
hardware can be set to EIM mode when userspace local APIC is used.

Suggested-by: Joao Martins <joao.m.martins@oracle.com>
Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
---
 hw/i386/intel_iommu.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 5085a6fee3..cb6ce4a646 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -4124,11 +4124,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
                                               ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;
     }
     if (s->intr_eim == ON_OFF_AUTO_ON && !s->buggy_eim) {
-        if (!kvm_irqchip_is_split()) {
-            error_setg(errp, "eim=on requires accel=kvm,kernel-irqchip=split");
-            return false;
-        }
-        if (kvm_enabled() && !kvm_enable_x2apic()) {
+        if (kvm_irqchip_is_split() && !kvm_enable_x2apic()) {
             error_setg(errp, "eim=on requires support on the KVM side"
                              "(X2APIC_API, first shipped in v4.7)");
             return false;
-- 
2.25.1



  parent reply	other threads:[~2023-11-09 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 15:19 [PATCH v10 0/7] Support x2APIC mode with TCG accelerator Bui Quang Minh
2023-11-09 15:19 ` [PATCH v10 1/7] i386/tcg: implement x2APIC registers MSR access Bui Quang Minh
2023-11-09 15:19 ` [PATCH v10 2/7] apic: add support for x2APIC mode Bui Quang Minh
2023-11-09 15:19 ` [PATCH v10 3/7] apic, i386/tcg: add x2apic transitions Bui Quang Minh
2023-11-09 15:19 ` Bui Quang Minh [this message]
2023-11-09 15:19 ` [PATCH v10 5/7] test: bios-tables-test: prepare IVRS change in ACPI table Bui Quang Minh
2023-11-09 15:19 ` [PATCH v10 6/7] amd_iommu: report x2APIC support to the operating system Bui Quang Minh
2023-11-09 15:19 ` [PATCH v10 7/7] test: bios-tables-test: add IVRS changed binary Bui Quang Minh
2023-12-25 15:59 ` [PATCH v10 0/7] Support x2APIC mode with TCG accelerator Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109151924.267515-5-minhquangbui99@gmail.com \
    --to=minhquangbui99@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=dwmw2@infradead.org \
    --cc=eduardo@habkost.net \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=lists@philjordan.eu \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=santosh.shukla@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).