qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "John Snow" <jsnow@redhat.com>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Beraldo Leal" <bleal@redhat.com>,
	"Rene Engel" <ReneEngel80@emailn.de>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Howard Spoelstra" <hsp.cat7@gmail.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 1/2] buildsys: Bump minimal meson version required to v1.2.3
Date: Thu,  9 Nov 2023 18:01:43 +0100	[thread overview]
Message-ID: <20231109170144.848401-1-pbonzini@redhat.com> (raw)
In-Reply-To: <20231109160504.93677-2-philmd@linaro.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

> We need meson v1.2.3 to build QEMU on macOS Sonoma.
> 
> It also build fine all our CI jobs, so let's use it as our
> "good enough" packaged wheel.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1939
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  python/wheels/meson-0.63.3-py3-none-any.whl | Bin 926526 -> 0 bytes
>  python/wheels/meson-1.2.3-py3-none-any.whl  | Bin 0 -> 964928 bytes
>  pythondeps.toml                             |   2 +-
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  delete mode 100644 python/wheels/meson-0.63.3-py3-none-any.whl
>  create mode 100644 python/wheels/meson-1.2.3-py3-none-any.whl
>
> diff --git a/pythondeps.toml b/pythondeps.toml
> index 0a35ebcf9f..a2f8c1980b 100644
> --- a/pythondeps.toml
> +++ b/pythondeps.toml
> @@ -18,7 +18,7 @@
>
>  [meson]
>  # The install key should match the version in python/wheels/
> -meson = { accepted = ">=0.63.0", installed = "0.63.3", canary = "meson" }
> +meson = { accepted = ">=1.2.3", installed = "1.2.3", canary = "meson" }

We don't need to block older versions of Meson, and indeed we don't
want to because it's fine to use the distro package everywhere
(including Sonoma).  (So the subject would become would be
"buildsys: Bump known good meson version to v1.2.3).

You can look at sphinx below for another case where the accepted
versions are much older than the installed one.

If there's anything you'd like to add to the (just sent) documentation
to clarify this, please help.

Paolo

> 
>  [docs]
>  sphinx = { accepted = ">=1.6", installed = "5.3.0", canary = "sphinx-build" }



  reply	other threads:[~2023-11-09 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 16:05 [PATCH v2 0/2] buildsys: Bump meson version to build on macOS Sonoma Philippe Mathieu-Daudé
2023-11-09 16:05 ` [PATCH v2 1/2] buildsys: Bump minimal meson version required to v1.2.3 Philippe Mathieu-Daudé
2023-11-09 17:01   ` Paolo Bonzini [this message]
2023-11-09 21:21     ` John Snow
2023-11-09 22:00       ` BALATON Zoltan
2023-11-10  8:34         ` Paolo Bonzini
2023-11-09 22:10       ` Philippe Mathieu-Daudé
2023-11-09 22:12     ` Philippe Mathieu-Daudé
2023-11-09 16:05 ` [PATCH v2 2/2] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma) Philippe Mathieu-Daudé
2023-11-09 17:30 ` [PATCH v2 0/2] buildsys: Bump meson version to build on macOS Sonoma Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109170144.848401-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ReneEngel80@emailn.de \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=hsp.cat7@gmail.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).