From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com,
peter.maydell@linaro.org, pbonzini@redhat.com, philmd@linaro.org
Subject: [PATCH v3 08/11] hw/rx/rx62n: Use qdev_prop_set_array()
Date: Thu, 9 Nov 2023 18:42:37 +0100 [thread overview]
Message-ID: <20231109174240.72376-9-kwolf@redhat.com> (raw)
In-Reply-To: <20231109174240.72376-1-kwolf@redhat.com>
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/rx/rx62n.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/hw/rx/rx62n.c b/hw/rx/rx62n.c
index d00fcb0ef0..4dc44afd9d 100644
--- a/hw/rx/rx62n.c
+++ b/hw/rx/rx62n.c
@@ -28,6 +28,7 @@
#include "hw/sysbus.h"
#include "hw/qdev-properties.h"
#include "sysemu/sysemu.h"
+#include "qapi/qmp/qlist.h"
#include "qom/object.h"
/*
@@ -130,22 +131,22 @@ static void register_icu(RX62NState *s)
{
int i;
SysBusDevice *icu;
+ QList *ipr_map, *trigger_level;
object_initialize_child(OBJECT(s), "icu", &s->icu, TYPE_RX_ICU);
icu = SYS_BUS_DEVICE(&s->icu);
- qdev_prop_set_uint32(DEVICE(icu), "len-ipr-map", NR_IRQS);
+
+ ipr_map = qlist_new();
for (i = 0; i < NR_IRQS; i++) {
- char propname[32];
- snprintf(propname, sizeof(propname), "ipr-map[%d]", i);
- qdev_prop_set_uint32(DEVICE(icu), propname, ipr_table[i]);
+ qlist_append_int(ipr_map, ipr_table[i]);
}
- qdev_prop_set_uint32(DEVICE(icu), "len-trigger-level",
- ARRAY_SIZE(levelirq));
+ qdev_prop_set_array(DEVICE(icu), "ipr-map", ipr_map);
+
+ trigger_level = qlist_new();
for (i = 0; i < ARRAY_SIZE(levelirq); i++) {
- char propname[32];
- snprintf(propname, sizeof(propname), "trigger-level[%d]", i);
- qdev_prop_set_uint32(DEVICE(icu), propname, levelirq[i]);
+ qlist_append_int(trigger_level, levelirq[i]);
}
+ qdev_prop_set_array(DEVICE(icu), "trigger-level", trigger_level);
for (i = 0; i < NR_IRQS; i++) {
s->irq[i] = qdev_get_gpio_in(DEVICE(icu), i);
--
2.41.0
next prev parent reply other threads:[~2023-11-09 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:42 [PATCH v3 00/11] qdev: Make array properties user accessible again Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array() Kevin Wolf
2023-11-09 19:11 ` Philippe Mathieu-Daudé
2023-11-09 17:42 ` [PATCH v3 02/11] hw/arm/mps2-tz: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 03/11] hw/arm/mps2: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 04/11] hw/arm/sbsa-ref: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 05/11] hw/arm/vexpress: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 06/11] hw/arm/virt: " Kevin Wolf
2023-11-09 17:42 ` [PATCH v3 07/11] hw/arm/xlnx-versal: " Kevin Wolf
2023-11-09 17:42 ` Kevin Wolf [this message]
2023-11-09 17:42 ` [PATCH v3 09/11] qom: Add object_property_set_default_list() Kevin Wolf
2023-11-09 19:12 ` Philippe Mathieu-Daudé
2023-11-09 17:42 ` [PATCH v3 10/11] qdev: Make netdev properties work as list elements Kevin Wolf
2023-11-09 19:13 ` Philippe Mathieu-Daudé
2023-11-09 17:42 ` [PATCH v3 11/11] qdev: Rework array properties based on list visitor Kevin Wolf
2023-11-09 19:14 ` [PATCH v3 00/11] qdev: Make array properties user accessible again Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109174240.72376-9-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).