qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glenn Miles <milesg@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: "Glenn Miles" <milesg@linux.vnet.ibm.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Frédéric Barrat" <fbarrat@linux.ibm.com>
Subject: [PATCH v2 2/8] ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power control
Date: Fri, 10 Nov 2023 13:49:19 -0600	[thread overview]
Message-ID: <20231110194925.475909-3-milesg@linux.vnet.ibm.com> (raw)
In-Reply-To: <20231110194925.475909-1-milesg@linux.vnet.ibm.com>

For power10, a pca9552 device is used for PCIe slot hotplug power
control by the Power Hypervisor code.  The code expects that some
time after it enables power to a PCIe slot by asserting one of the
pca9552 GPIO pins 0-4, it should see a "power good" signal asserted
on one of pca9552 GPIO pins 5-9.

To simulate this behavior, we simply connect the GPIO outputs for
pins 0-4 to the GPIO inputs for pins 5-9.

Each PCIe slot is assigned 3 GPIO pins on the pca9552 device, for
control of up to 5 PCIe slots.  The per-slot signal names are:

   SLOTx_EN.......PHYP uses this as an output to enable
                  slot power.  We connect this to the
                  SLOTx_PG pin to simulate a PGOOD signal.
   SLOTx_PG.......PHYP uses this as in input to detect
                  PGOOD for the slot.  For our purposes
                  we just connect this to the SLOTx_EN
                  output.
   SLOTx_Control..PHYP uses this as an output to prevent
                  a race condition in the real hotplug
                  circuitry, but we can ignore this output
                  for simulation.

Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
---
 hw/ppc/pnv.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 7afaf1008f..0b24d7d8ed 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1882,7 +1882,24 @@ static void pnv_chip_power10_realize(DeviceState *dev, Error **errp)
      * Add a PCA9552 I2C device for PCIe hotplug control
      * to engine 2, bus 1, address 0x63
      */
-    i2c_slave_create_simple(chip10->i2c[2].busses[1], "pca9552", 0x63);
+    I2CSlave* hotplug = i2c_slave_create_simple(chip10->i2c[2].busses[1],
+                                                "pca9552", 0x63);
+
+    /*
+     * Connect PCA9552 GPIO pins 0-4 (SLOTx_EN) outputs to GPIO pins 5-9
+     * (SLOTx_PG) inputs in order to fake the pgood state of PCIe slots after
+     * hypervisor code sets a SLOTx_EN pin high.
+     */
+    qdev_connect_gpio_out(DEVICE(hotplug), 0,
+                          qdev_get_gpio_in(DEVICE(hotplug), 5));
+    qdev_connect_gpio_out(DEVICE(hotplug), 1,
+                          qdev_get_gpio_in(DEVICE(hotplug), 6));
+    qdev_connect_gpio_out(DEVICE(hotplug), 2,
+                          qdev_get_gpio_in(DEVICE(hotplug), 7));
+    qdev_connect_gpio_out(DEVICE(hotplug), 3,
+                          qdev_get_gpio_in(DEVICE(hotplug), 8));
+    qdev_connect_gpio_out(DEVICE(hotplug), 4,
+                          qdev_get_gpio_in(DEVICE(hotplug), 9));
 
 }
 
-- 
2.31.1



  parent reply	other threads:[~2023-11-10 19:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10 19:49 [PATCH v2 0/8] Add powernv10 I2C devices and tests Glenn Miles
2023-11-10 19:49 ` [PATCH v2 1/8] ppc/pnv: Add pca9552 to powernv10 for PCIe hotplug power control Glenn Miles
2023-11-13  9:05   ` Cédric Le Goater
2023-11-13 17:40     ` Miles Glenn
2023-11-10 19:49 ` Glenn Miles [this message]
2023-11-10 19:49 ` [PATCH v2 3/8] ppc/pnv: PNV I2C engines assigned incorrect XSCOM addresses Glenn Miles
2023-11-13  9:07   ` Cédric Le Goater
2023-11-14 15:27     ` Miles Glenn
2023-11-10 19:49 ` [PATCH v2 4/8] ppc/pnv: Fix PNV I2C invalid status after reset Glenn Miles
2023-11-13  9:10   ` Cédric Le Goater
2023-11-14 15:26     ` Miles Glenn
2023-11-14 17:55       ` Cédric Le Goater
2023-11-14 18:34         ` Miles Glenn
2023-11-10 19:49 ` [PATCH v2 5/8] ppc/pnv: Use resettable interface to reset child I2C buses Glenn Miles
2023-11-10 19:49 ` [PATCH v2 6/8] misc: Add a pca9554 GPIO device model Glenn Miles
2023-11-10 19:49 ` [PATCH v2 7/8] ppc/pnv: Add a pca9554 I2C device to powernv10 Glenn Miles
2023-11-10 19:49 ` [PATCH v2 8/8] ppc/pnv: Test pnv i2c master and connected devices Glenn Miles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110194925.475909-3-milesg@linux.vnet.ibm.com \
    --to=milesg@linux.vnet.ibm.com \
    --cc=clg@kaod.org \
    --cc=fbarrat@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).