From: Robert Hoo <robert.hoo.linux@gmail.com>
To: qemu-devel@nongnu.org, mst@redhat.com, marcel.apfelbaum@gmail.com
Cc: Robert Hoo <robert.hoo.linux@gmail.com>
Subject: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback
Date: Mon, 13 Nov 2023 16:13:49 +0800 [thread overview]
Message-ID: <20231113081349.1307-1-robert.hoo.linux@gmail.com> (raw)
In the rollback in msix_set_vector_notifiers(), original patch forgot to
undo msix_vector_poll_notifier pointer.
Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll")
Signed-off-by: Robert Hoo <robert.hoo.linux@gmail.com>
---
hw/pci/msix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index ab8869d9d0..cd817f4ca8 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -648,6 +648,7 @@ undo:
}
dev->msix_vector_use_notifier = NULL;
dev->msix_vector_release_notifier = NULL;
+ dev->msix_vector_poll_notifier = NULL;
return ret;
}
--
2.39.3
next reply other threads:[~2023-11-13 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 8:13 Robert Hoo [this message]
2023-11-13 10:05 ` [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback Philippe Mathieu-Daudé
2023-11-13 13:03 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113081349.1307-1-robert.hoo.linux@gmail.com \
--to=robert.hoo.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).