qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Volker Rümelin" <vr_qemu@t-online.de>
Subject: [PULL 12/12] hw/audio/es1370: Clean up comment
Date: Mon, 13 Nov 2023 12:07:40 +0100	[thread overview]
Message-ID: <20231113110740.38270-13-thuth@redhat.com> (raw)
In-Reply-To: <20231113110740.38270-1-thuth@redhat.com>

From: Peter Maydell <peter.maydell@linaro.org>

Replace a sweary comment with one that's a bit more helpful to
future readers of the code.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>
Message-ID: <20231110164318.2197569-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/audio/es1370.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
index 91c47330ad..fad5541211 100644
--- a/hw/audio/es1370.c
+++ b/hw/audio/es1370.c
@@ -670,8 +670,13 @@ static void es1370_transfer_audio (ES1370State *s, struct chan *d, int loop_sel,
     cnt += (transferred + d->leftover) >> 2;
 
     if (s->sctl & loop_sel) {
-        /* Bah, how stupid is that having a 0 represent true value?
-           i just spent few hours on this shit */
+        /*
+         * loop_sel tells us which bit in the SCTL register to look at
+         * (either P1_LOOP_SEL, P2_LOOP_SEL or R1_LOOP_SEL). The sense
+         * of these bits is 0 for loop mode (set interrupt and keep recording
+         * when the sample count reaches zero) or 1 for stop mode (set
+         * interrupt and stop recording).
+         */
         AUD_log ("es1370: warning", "non looping mode\n");
     } else {
         d->frame_cnt = size;
-- 
2.41.0



  parent reply	other threads:[~2023-11-13 11:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 11:07 [PULL 00/12] Misc patches for 8.2-rc0 Thomas Huth
2023-11-13 11:07 ` [PULL 01/12] host/include/generic/host/atomic128: Fix compilation problem with Clang 17 Thomas Huth
2023-11-13 11:07 ` [PULL 02/12] s390x/pci: bypass vfio DMA counting when using cdev Thomas Huth
2023-11-13 11:07 ` [PULL 03/12] s390x/pci: only limit DMA aperture if vfio DMA limit reported Thomas Huth
2023-11-13 11:07 ` [PULL 04/12] MAINTAINERS: Add include/hw/input/pl050.h to the PrimeCell/CMSDK section Thomas Huth
2023-11-13 11:07 ` [PULL 05/12] MAINTAINERS: Add hw/input/ads7846.c to the PXA2XX section Thomas Huth
2023-11-13 11:07 ` [PULL 06/12] MAINTAINERS: Add hw/display/sii9022.c to the Versatile Express section Thomas Huth
2023-11-13 11:07 ` [PULL 07/12] MAINTAINERS: Extend the Stellaris section Thomas Huth
2023-11-13 11:07 ` [PULL 08/12] MAINTAINERS: Add a general architecture section for x86 Thomas Huth
2023-11-13 11:07 ` [PULL 09/12] tests/vm/netbsd: Use Python v3.11 Thomas Huth
2023-11-13 11:07 ` [PULL 10/12] test-resv-mem: Fix CID 1523911 Thomas Huth
2023-11-13 11:07 ` [PULL 11/12] tests/tsan: Rename the file with the entries that should be ignored Thomas Huth
2023-11-13 11:07 ` Thomas Huth [this message]
2023-11-13 19:27 ` [PULL 00/12] Misc patches for 8.2-rc0 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231113110740.38270-13-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).