qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
	"Alexandra Diupina" <adiupina@astralinux.ru>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 2/5] hw/display/vmware_vga: fix probably typo
Date: Mon, 13 Nov 2023 19:17:41 +0100	[thread overview]
Message-ID: <20231113181744.49537-3-philmd@linaro.org> (raw)
In-Reply-To: <20231113181744.49537-1-philmd@linaro.org>

From: Alexandra Diupina <adiupina@astralinux.ru>

When calling trace_vmware_verify_rect_greater_than_bound() replace
"y" with "h" and y with h

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events")
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231110174104.13280-1-adiupina@astralinux.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/display/vmware_vga.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 7490d43881..3f26bea190 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -336,8 +336,8 @@ static inline bool vmsvga_verify_rect(DisplaySurface *surface,
         return false;
     }
     if (h > SVGA_MAX_HEIGHT) {
-        trace_vmware_verify_rect_greater_than_bound(name, "y", SVGA_MAX_HEIGHT,
-                                                    y);
+        trace_vmware_verify_rect_greater_than_bound(name, "h", SVGA_MAX_HEIGHT,
+                                                    h);
         return false;
     }
     if (y + h > surface_height(surface)) {
-- 
2.41.0



  parent reply	other threads:[~2023-11-13 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 18:17 [PULL 0/5] Misc fixes for 2023-11-13 Philippe Mathieu-Daudé
2023-11-13 18:17 ` [PULL 1/5] hw/mips: LOONGSON3V depends on UNIMP device Philippe Mathieu-Daudé
2023-11-13 18:17 ` Philippe Mathieu-Daudé [this message]
2023-11-13 18:17 ` [PULL 3/5] tests/avocado: add test to exercise processor address space memory bound checks Philippe Mathieu-Daudé
2023-11-13 18:17 ` [PULL 4/5] tests/avocado/machine_s390_ccw_virtio.py: Fix SyntaxWarnings from python 3.12 Philippe Mathieu-Daudé
2023-11-13 18:17 ` [PULL 5/5] MAINTAINERS: update virtio-fs mailing list address Philippe Mathieu-Daudé
2023-11-14 17:31 ` [PULL 0/5] Misc fixes for 2023-11-13 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231113181744.49537-3-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=adiupina@astralinux.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).