From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org,
"Arnaud Minier" <arnaud.minier@telecom-paris.fr>,
"Inès Varhol" <ines.varhol@telecom-paris.fr>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Hao Wu" <wuhaotsh@google.com>, "Felipe Balbi" <balbi@kernel.org>,
"Gavin Shan" <gshan@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Alistair Francis" <alistair@alistair23.me>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH-for-8.2? 0/6] hw/arm/stm32xxx: Report error when incorrect CPU is used
Date: Thu, 16 Nov 2023 00:21:47 +0100 [thread overview]
Message-ID: <20231115232154.4515-1-philmd@linaro.org> (raw)
Hi,
While reviewing this [1] series from Arnaud and Inès,
I realized STM32 based boards don't check the requested
CPU type is correct, and ignore it. Possibly confusing
users.
Since these simple boards code is used as template,
I took the opportunity to sanitize it a bit, using the
MachineClass::valid_cpu_types which seems simpler (to me)
for newcomers.
First 3 patches are candidate for 8.2 but this is a long
standing issue, not a regression from 8.1.
Other patches are similar cleanups, for 9.0. Besides, the
CPU list output will be nicer with Gavin Shan work [2]
integrated.
Regards,
Phil.
[1] https://lore.kernel.org/qemu-devel/170003673257.14701.8139061802716120109-0@git.sr.ht/
[2] https://lore.kernel.org/qemu-devel/20231114235628.534334-1-gshan@redhat.com/
Philippe Mathieu-Daudé (6):
hw/arm/stm32f405: Report error when incorrect CPU is used
hw/arm/stm32f205: Report error when incorrect CPU is used
hw/arm/stm32f100: Report error when incorrect CPU is used
hw/arm/msf2: Simplify setting MachineClass::valid_cpu_types[]
hw/arm/npcm7xx_boards: Simplify setting
MachineClass::valid_cpu_types[]
hw/arm/musca: Simplify setting MachineClass::valid_cpu_types[]
include/hw/arm/msf2-soc.h | 3 ---
include/hw/arm/stm32f100_soc.h | 4 ----
include/hw/arm/stm32f205_soc.h | 4 ----
include/hw/arm/stm32f405_soc.h | 4 ----
hw/arm/msf2-soc.c | 3 +--
hw/arm/msf2-som.c | 16 ++++++----------
hw/arm/musca.c | 13 +++++--------
hw/arm/netduino2.c | 7 ++++++-
hw/arm/netduinoplus2.c | 7 ++++++-
hw/arm/npcm7xx_boards.c | 13 +++++--------
hw/arm/olimex-stm32-h405.c | 8 ++++++--
hw/arm/stm32f100_soc.c | 9 ++-------
hw/arm/stm32f205_soc.c | 9 ++-------
hw/arm/stm32f405_soc.c | 8 +-------
hw/arm/stm32vldiscovery.c | 7 ++++++-
15 files changed, 46 insertions(+), 69 deletions(-)
--
2.41.0
next reply other threads:[~2023-11-15 23:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 23:21 Philippe Mathieu-Daudé [this message]
2023-11-15 23:21 ` [PATCH-for-8.2? 1/6] hw/arm/stm32f405: Report error when incorrect CPU is used Philippe Mathieu-Daudé
2023-11-16 7:23 ` Philippe Mathieu-Daudé
2023-11-15 23:21 ` [PATCH-for-8.2? 2/6] hw/arm/stm32f205: " Philippe Mathieu-Daudé
2023-11-15 23:21 ` [PATCH-for-8.2? 3/6] hw/arm/stm32f100: " Philippe Mathieu-Daudé
2023-11-16 7:25 ` Philippe Mathieu-Daudé
2023-11-15 23:21 ` [PATCH-for-9.0 4/6] hw/arm/msf2: Simplify setting MachineClass::valid_cpu_types[] Philippe Mathieu-Daudé
2023-11-15 23:21 ` [PATCH-for-9.0 5/6] hw/arm/npcm7xx_boards: " Philippe Mathieu-Daudé
2023-11-15 23:21 ` [PATCH-for-9.0 6/6] hw/arm/musca: " Philippe Mathieu-Daudé
2023-11-16 16:46 ` [PATCH-for-8.2? 0/6] hw/arm/stm32xxx: Report error when incorrect CPU is used Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115232154.4515-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=arnaud.minier@telecom-paris.fr \
--cc=balbi@kernel.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=ines.varhol@telecom-paris.fr \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sbhatta@marvell.com \
--cc=sundeep.lkml@gmail.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).