qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: [PULL 1/7] spapr/pci: Correct "does not support hotplugging error messages
Date: Fri, 17 Nov 2023 10:53:28 +0100	[thread overview]
Message-ID: <20231117095334.1819613-2-armbru@redhat.com> (raw)
In-Reply-To: <20231117095334.1819613-1-armbru@redhat.com>

When dynamic-reconfiguration is off, hot plug / unplug can fail with
"Bus 'spapr-pci-host-bridge' does not support hotplugging".
spapr-pci-host-bridge is a device, not a bus.  Report the name of the
bus it provides instead: 'pci.0'.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-2-armbru@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/spapr_pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index a27024e45a..6760823e13 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1555,7 +1555,7 @@ static void spapr_pci_pre_plug(HotplugHandler *plug_handler,
          */
         if (plugged_dev->hotplugged) {
             error_setg(errp, QERR_BUS_NO_HOTPLUG,
-                       object_get_typename(OBJECT(phb)));
+                       phb->parent_obj.bus->qbus.name);
             return;
         }
     }
@@ -1676,7 +1676,7 @@ static void spapr_pci_unplug_request(HotplugHandler *plug_handler,
 
     if (!phb->dr_enabled) {
         error_setg(errp, QERR_BUS_NO_HOTPLUG,
-                   object_get_typename(OBJECT(phb)));
+                   phb->parent_obj.bus->qbus.name);
         return;
     }
 
-- 
2.41.0



  reply	other threads:[~2023-11-17  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  9:53 [PULL 0/7] Error reporting patches for 2023-11-17 Markus Armbruster
2023-11-17  9:53 ` Markus Armbruster [this message]
2023-11-17  9:53 ` [PULL 2/7] hmp: Improve sync-profile error message Markus Armbruster
2023-11-17  9:53 ` [PULL 3/7] qga: Improve guest-exec-status " Markus Armbruster
2023-11-17  9:53 ` [PULL 4/7] ui/qmp-cmds: Improve two error messages Markus Armbruster
2023-11-17  9:53 ` [PULL 5/7] net: Fix a misleading error message Markus Armbruster
2023-11-17  9:53 ` [PULL 6/7] balloon: " Markus Armbruster
2023-11-17  9:53 ` [PULL 7/7] target/i386/cpu: Improve error message for property "vendor" Markus Armbruster
2023-11-20 14:39 ` [PULL 0/7] Error reporting patches for 2023-11-17 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231117095334.1819613-2-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).