From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: [PULL 2/7] hmp: Improve sync-profile error message
Date: Fri, 17 Nov 2023 10:53:29 +0100 [thread overview]
Message-ID: <20231117095334.1819613-3-armbru@redhat.com> (raw)
In-Reply-To: <20231117095334.1819613-1-armbru@redhat.com>
Improve
(qemu) sync-profile of
Error: Invalid parameter 'of'
to
Error: invalid parameter 'of', expecting 'on', 'off', or 'reset'
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
---
monitor/hmp-cmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 6c559b48c8..871898ac46 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -24,7 +24,6 @@
#include "qapi/qapi-commands-control.h"
#include "qapi/qapi-commands-misc.h"
#include "qapi/qmp/qdict.h"
-#include "qapi/qmp/qerror.h"
#include "qemu/cutils.h"
#include "hw/intc/intc.h"
#include "qemu/log.h"
@@ -138,7 +137,8 @@ void hmp_sync_profile(Monitor *mon, const QDict *qdict)
} else {
Error *err = NULL;
- error_setg(&err, QERR_INVALID_PARAMETER, op);
+ error_setg(&err, "invalid parameter '%s',"
+ " expecting 'on', 'off', or 'reset'", op);
hmp_handle_error(mon, err);
}
}
--
2.41.0
next prev parent reply other threads:[~2023-11-17 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:53 [PULL 0/7] Error reporting patches for 2023-11-17 Markus Armbruster
2023-11-17 9:53 ` [PULL 1/7] spapr/pci: Correct "does not support hotplugging error messages Markus Armbruster
2023-11-17 9:53 ` Markus Armbruster [this message]
2023-11-17 9:53 ` [PULL 3/7] qga: Improve guest-exec-status error message Markus Armbruster
2023-11-17 9:53 ` [PULL 4/7] ui/qmp-cmds: Improve two error messages Markus Armbruster
2023-11-17 9:53 ` [PULL 5/7] net: Fix a misleading error message Markus Armbruster
2023-11-17 9:53 ` [PULL 6/7] balloon: " Markus Armbruster
2023-11-17 9:53 ` [PULL 7/7] target/i386/cpu: Improve error message for property "vendor" Markus Armbruster
2023-11-20 14:39 ` [PULL 0/7] Error reporting patches for 2023-11-17 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117095334.1819613-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).