From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, David Hildenbrand <david@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Mario Casquero <mcasquer@redhat.com>
Subject: [PULL 6/7] balloon: Fix a misleading error message
Date: Fri, 17 Nov 2023 10:53:33 +0100 [thread overview]
Message-ID: <20231117095334.1819613-7-armbru@redhat.com> (raw)
In-Reply-To: <20231117095334.1819613-1-armbru@redhat.com>
The error message
{"execute": "balloon", "arguments":{"value": -1}}
{"error": {"class": "GenericError", "desc": "Parameter 'target' expects a size"}}
points to 'target' instead of 'value'. Fix:
{"error": {"class": "GenericError", "desc": "Parameter 'value' expects a size"}}
Root cause: qmp_balloon()'s parameter is named @target. Rename it to
@value to match the QAPI schema.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-7-armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Mario Casquero <mcasquer@redhat.com>
---
system/balloon.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/system/balloon.c b/system/balloon.c
index e0e8969a4b..fda7af832e 100644
--- a/system/balloon.c
+++ b/system/balloon.c
@@ -90,17 +90,17 @@ BalloonInfo *qmp_query_balloon(Error **errp)
return info;
}
-void qmp_balloon(int64_t target, Error **errp)
+void qmp_balloon(int64_t value, Error **errp)
{
if (!have_balloon(errp)) {
return;
}
- if (target <= 0) {
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size");
+ if (value <= 0) {
+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "value", "a size");
return;
}
- trace_balloon_event(balloon_opaque, target);
- balloon_event_fn(balloon_opaque, target);
+ trace_balloon_event(balloon_opaque, value);
+ balloon_event_fn(balloon_opaque, value);
}
--
2.41.0
next prev parent reply other threads:[~2023-11-17 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:53 [PULL 0/7] Error reporting patches for 2023-11-17 Markus Armbruster
2023-11-17 9:53 ` [PULL 1/7] spapr/pci: Correct "does not support hotplugging error messages Markus Armbruster
2023-11-17 9:53 ` [PULL 2/7] hmp: Improve sync-profile error message Markus Armbruster
2023-11-17 9:53 ` [PULL 3/7] qga: Improve guest-exec-status " Markus Armbruster
2023-11-17 9:53 ` [PULL 4/7] ui/qmp-cmds: Improve two error messages Markus Armbruster
2023-11-17 9:53 ` [PULL 5/7] net: Fix a misleading error message Markus Armbruster
2023-11-17 9:53 ` Markus Armbruster [this message]
2023-11-17 9:53 ` [PULL 7/7] target/i386/cpu: Improve error message for property "vendor" Markus Armbruster
2023-11-20 14:39 ` [PULL 0/7] Error reporting patches for 2023-11-17 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117095334.1819613-7-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=mcasquer@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).