From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12D6AC072A2 for ; Fri, 17 Nov 2023 11:47:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3xIH-0005Bd-2b; Fri, 17 Nov 2023 06:45:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3xIE-00053U-Bx for qemu-devel@nongnu.org; Fri, 17 Nov 2023 06:45:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3xIC-0005lF-Ek for qemu-devel@nongnu.org; Fri, 17 Nov 2023 06:45:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700221547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JMwA2exvHcZa0kAtMAf8cm5j+0XIzutQz5UtRrDNTfU=; b=L8dBj2kgBn/79KsRVMCOxcY7OZsgxIL6X74Tyv+tk8pLQylkoUhm5/qp2ifP1ewlsgvQKb wZqahP0lVpS1XeINxsaeDtvsufOedPHBY62iq5iGqavUqBVUCJa0cw49aYaOsykG0pkPLN AVnEius3WbUseFnK1lyCVfDh4+bhrdI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-d-f4LL3eOIWlLQor1U9XBQ-1; Fri, 17 Nov 2023 06:45:41 -0500 X-MC-Unique: d-f4LL3eOIWlLQor1U9XBQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB7053C01E08; Fri, 17 Nov 2023 11:45:40 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.194.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 946145028; Fri, 17 Nov 2023 11:45:37 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster Cc: Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , Paolo Bonzini , Peter Xu , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Francisco Iglesias , Eduardo Habkost , Thomas Huth Subject: [PATCH v3 0/5] Limit type names to alphanumerical and some few special characters Date: Fri, 17 Nov 2023 12:44:52 +0100 Message-ID: <20231117114457.177308-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.117, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To avoid that such problematic type names come in again, let's restrict the set of acceptable characters during the type registration. First four patches are clean-ups related to comma and colons in type names, and the final patch introduces the check for valid names. v3: - Added Reviewed-bys to the first four patches - Changed last patch to use strspn() as suggested by Daniel v2: - Include Markus' patches in the series - Add patches to clean up colons in type names - Add the check to type_register_internal() instead of type_new() so that we can disallow colons, too - Only allow '+' in legacy names Markus Armbruster (2): docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl" hw: Replace anti-social QOM type names (again) Thomas Huth (3): memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name qom/object: Limit type names to alphanumerical and some few special characters docs/system/arm/xlnx-versal-virt.rst | 4 +-- include/exec/memory.h | 2 +- include/hw/misc/xlnx-versal-cframe-reg.h | 2 +- include/hw/misc/xlnx-versal-cfu.h | 6 ++-- include/hw/misc/xlnx-versal-crl.h | 2 +- include/hw/nvram/xlnx-efuse.h | 2 +- include/hw/nvram/xlnx-versal-efuse.h | 4 +-- include/hw/nvram/xlnx-zynqmp-efuse.h | 2 +- qom/object.c | 41 ++++++++++++++++++++++++ tests/unit/test-io-task.c | 2 +- 10 files changed, 54 insertions(+), 13 deletions(-) -- 2.42.0