qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com, jgg@nvidia.com,
	nicolinc@nvidia.com, joao.m.martins@oracle.com,
	eric.auger@redhat.com, peterx@redhat.com, jasowang@redhat.com,
	kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com,
	chao.p.peng@intel.com
Subject: [PATCH v7 05/27] vfio/iommufd: Relax assert check for iommufd backend
Date: Tue, 21 Nov 2023 16:44:04 +0800	[thread overview]
Message-ID: <20231121084426.1286987-6-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20231121084426.1286987-1-zhenzhong.duan@intel.com>

Currently iommufd doesn't support dirty page sync yet,
but it will not block us doing live migration if VFIO
migration is force enabled.

So in this case we allow set_dirty_page_tracking to be NULL.
Note we don't need same change for query_dirty_bitmap because
when dirty page sync isn't supported, query_dirty_bitmap will
never be called.

Suggested-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
---
 hw/vfio/container-base.c | 4 ++++
 hw/vfio/container.c      | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/vfio/container-base.c b/hw/vfio/container-base.c
index 71f7274973..eee2dcfe76 100644
--- a/hw/vfio/container-base.c
+++ b/hw/vfio/container-base.c
@@ -55,6 +55,10 @@ void vfio_container_del_section_window(VFIOContainerBase *bcontainer,
 int vfio_container_set_dirty_page_tracking(VFIOContainerBase *bcontainer,
                                            bool start)
 {
+    if (!bcontainer->dirty_pages_supported) {
+        return 0;
+    }
+
     g_assert(bcontainer->ops->set_dirty_page_tracking);
     return bcontainer->ops->set_dirty_page_tracking(bcontainer, start);
 }
diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 6bacf38222..ed2d721b2b 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -216,10 +216,6 @@ static int vfio_legacy_set_dirty_page_tracking(VFIOContainerBase *bcontainer,
         .argsz = sizeof(dirty),
     };
 
-    if (!bcontainer->dirty_pages_supported) {
-        return 0;
-    }
-
     if (start) {
         dirty.flags = VFIO_IOMMU_DIRTY_PAGES_FLAG_START;
     } else {
-- 
2.34.1



  parent reply	other threads:[~2023-11-21  8:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  8:43 [PATCH v7 00/27] vfio: Adopt iommufd Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 01/27] backends/iommufd: Introduce the iommufd object Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 02/27] util/char_dev: Add open_cdev() Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 03/27] vfio/common: return early if space isn't empty Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 04/27] vfio/iommufd: Implement the iommufd backend Zhenzhong Duan
2023-11-21  8:44 ` Zhenzhong Duan [this message]
2023-11-21  8:44 ` [PATCH v7 06/27] vfio/iommufd: Add support for iova_ranges and pgsizes Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 07/27] vfio/pci: Extract out a helper vfio_pci_get_pci_hot_reset_info Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 08/27] vfio/pci: Introduce a vfio pci hot reset interface Zhenzhong Duan
2023-11-21 18:38   ` Philippe Mathieu-Daudé
2023-11-22  3:32     ` Duan, Zhenzhong
2023-11-21  8:44 ` [PATCH v7 09/27] vfio/iommufd: Enable pci hot reset through iommufd cdev interface Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 10/27] vfio/pci: Allow the selection of a given iommu backend Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 11/27] vfio/pci: Make vfio cdev pre-openable by passing a file handle Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 12/27] vfio/platform: Allow the selection of a given iommu backend Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 13/27] vfio/platform: Make vfio cdev pre-openable by passing a file handle Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 14/27] vfio/ap: Allow the selection of a given iommu backend Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 15/27] vfio/ap: Make vfio cdev pre-openable by passing a file handle Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 16/27] vfio/ccw: Allow the selection of a given iommu backend Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 17/27] vfio/ccw: Make vfio cdev pre-openable by passing a file handle Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 18/27] vfio: Make VFIOContainerBase poiner parameter const in VFIOIOMMUOps callbacks Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 19/27] hw/arm: Activate IOMMUFD for virt machines Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 20/27] kconfig: Activate IOMMUFD for s390x machines Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 21/27] hw/i386: Activate IOMMUFD for q35 machines Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 22/27] vfio/pci: Move VFIODevice initializations in vfio_instance_init Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 23/27] vfio/platform: Move VFIODevice initializations in vfio_platform_instance_init Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 24/27] vfio/ap: Move VFIODevice initializations in vfio_ap_instance_init Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 25/27] vfio/ccw: Move VFIODevice initializations in vfio_ccw_instance_init Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 26/27] vfio: Introduce a helper function to initialize VFIODevice Zhenzhong Duan
2023-11-21  8:44 ` [PATCH v7 27/27] docs/devel: Add VFIO iommufd backend documentation Zhenzhong Duan
2023-11-21 17:22 ` [PATCH v7 00/27] vfio: Adopt iommufd Cédric Le Goater
2023-11-22  3:21   ` Duan, Zhenzhong
2023-11-22  8:06     ` Cédric Le Goater
2023-11-22 11:49       ` Duan, Zhenzhong
2023-11-21 22:56 ` Nicolin Chen
2023-11-22  3:32   ` Duan, Zhenzhong
2023-11-22 13:48 ` Joao Martins
2023-11-28 17:10 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121084426.1286987-6-zhenzhong.duan@intel.com \
    --to=zhenzhong.duan@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=chao.p.peng@intel.com \
    --cc=clg@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kevin.tian@intel.com \
    --cc=nicolinc@nvidia.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).