* [PATCH] configure: Make only once with pseudo-"in source tree" builds
@ 2023-11-19 10:16 Akihiko Odaki
2023-11-21 15:50 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2023-11-19 10:16 UTC (permalink / raw)
Cc: Akihiko Odaki, Paolo Bonzini, Alex Bennée, Thomas Huth,
qemu-devel
Pseudo-"in source tree" build used to run make in the build directory
as many times as goals. Worse, although .NOTPARALLEL is specified,
it does not work for patterns, and run make in parallel, which can break
things.
Add a new rule "build", and let it call make. The pattern rule only
needs to specify "build" as its prerequisite and have a no-op recipe so
that it does more than canceling built-in implicit rules.
Fixes: dedad02720 ("configure: add support for pseudo-"in source tree" builds")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
configure | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/configure b/configure
index abcb199aa8..d73a9d811b 100755
--- a/configure
+++ b/configure
@@ -41,12 +41,7 @@ then
# This file is auto-generated by configure to support in-source tree
# 'make' command invocation
-ifeq ($(MAKECMDGOALS),)
-recurse: all
-endif
-
-.NOTPARALLEL: %
-%: force
+build:
@echo 'changing dir to build for $(MAKE) "$(MAKECMDGOALS)"...'
@$(MAKE) -C build -f Makefile $(MAKECMDGOALS)
@if test "$(MAKECMDGOALS)" = "distclean" && \
@@ -54,8 +49,9 @@ endif
then \
rm -rf build GNUmakefile ; \
fi
-force: ;
-.PHONY: force
+%: build
+ @
+.PHONY: build
GNUmakefile: ;
EOF
--
2.42.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: Make only once with pseudo-"in source tree" builds
2023-11-19 10:16 [PATCH] configure: Make only once with pseudo-"in source tree" builds Akihiko Odaki
@ 2023-11-21 15:50 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2023-11-21 15:50 UTC (permalink / raw)
To: Akihiko Odaki
Cc: qemu-devel, Markus Armbruster, Peter Xu,
Philippe Mathieu-Daudé, David Hildenbrand, Alex Bennée,
Thomas Huth
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-21 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-19 10:16 [PATCH] configure: Make only once with pseudo-"in source tree" builds Akihiko Odaki
2023-11-21 15:50 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).