From: Igor Mammedov <imammedo@redhat.com>
To: Thierry Escande <thierry.escande@vates.tech>
Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct
Date: Fri, 24 Nov 2023 14:23:17 +0100 [thread overview]
Message-ID: <20231124142317.1fdbe16f@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20231115171837.18866-2-thierry.escande@vates.tech>
On Wed, 15 Nov 2023 17:18:53 +0000
Thierry Escande <thierry.escande@vates.tech> wrote:
> This patch removes the unused field use_acpi_hotplug_bridge from the
> ICH9LPCPMRegs structure as it is now part of AcpiPciHpState.
>
> Hotplug fields have been removed from piix4 state structure by commit
> 6536e427ce49 (pcihp: move fields enabling hotplug into AcpiPciHpState)
> so do the same for ich9.
>
> Signed-off-by: Thierry Escande <thierry.escande@vates.tech>
Reviewed-by:Igor Mammedov <imammedo@redhat.com>
> ---
> include/hw/acpi/ich9.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index 2faf7f0cae..4bc9aa1d11 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -57,7 +57,6 @@ typedef struct ICH9LPCPMRegs {
> CPUHotplugState cpuhp_state;
>
> bool keep_pci_slot_hpc;
> - bool use_acpi_hotplug_bridge;
> AcpiPciHpState acpi_pci_hotplug;
> MemHotplugState acpi_memory_hotplug;
>
next prev parent reply other threads:[~2023-11-24 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:18 [PATCH 0/4] ICH9 root PCI hotplug Thierry Escande
2023-11-15 17:18 ` [PATCH 2/4] ich9: Renamed use_acpi_hotplug_bridge accessors Thierry Escande
2023-11-15 17:18 ` [PATCH 3/4] ich9: Add accessors for acpi-root-pci-hotplug Thierry Escande
2023-11-15 17:18 ` [PATCH 1/4] ich9: Remove unused hotplug field from ICH9LPCPMRegs struct Thierry Escande
2023-11-15 20:48 ` Philippe Mathieu-Daudé
2023-11-24 13:23 ` Igor Mammedov [this message]
2023-11-15 17:18 ` [PATCH 4/4] ich9: Enable root PCI hotplug by default Thierry Escande
2023-11-24 13:37 ` Igor Mammedov
2023-11-24 13:39 ` Igor Mammedov
2023-11-24 14:01 ` [PATCH 0/4] ICH9 root PCI hotplug Igor Mammedov
2023-11-24 14:54 ` Michael S. Tsirkin
2023-11-29 9:47 ` Thierry Escande
2023-11-29 14:54 ` Michael S. Tsirkin
2023-12-07 17:04 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124142317.1fdbe16f@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thierry.escande@vates.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).