From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PULL 02/10] tests: respect --enable/--disable-download for Avocado
Date: Fri, 24 Nov 2023 16:24:00 +0100 [thread overview]
Message-ID: <20231124152408.140936-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20231124152408.140936-1-pbonzini@redhat.com>
Pass the content of $mkvenv_flags (which is either "--online"
or empty) down to tests/Makefile.include.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 9 +++++----
tests/Makefile.include | 2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 42fe4d05108..959b1a20c1c 100755
--- a/configure
+++ b/configure
@@ -968,14 +968,14 @@ meson="$(cd pyvenv/bin; pwd)/meson"
# Conditionally ensure Sphinx is installed.
-mkvenv_flags=""
-if test "$download" = "enabled" -a "$docs" = "enabled" ; then
- mkvenv_flags="--online"
+mkvenv_online_flag=""
+if test "$download" = "enabled" ; then
+ mkvenv_online_flag=" --online"
fi
if test "$docs" != "disabled" ; then
if ! $mkvenv ensuregroup \
- $mkvenv_flags \
+ $(test "$docs" = "enabled" && echo "$mkvenv_online_flag") \
${source_path}/pythondeps.toml docs;
then
if test "$docs" = "enabled" ; then
@@ -1634,6 +1634,7 @@ if test "$container" != no; then
fi
echo "SUBDIRS=$subdirs" >> $config_host_mak
echo "PYTHON=$python" >> $config_host_mak
+echo "MKVENV_ENSUREGROUP=$mkvenv ensuregroup $mkvenv_online_flag" >> $config_host_mak
echo "GENISOIMAGE=$genisoimage" >> $config_host_mak
echo "MESON=$meson" >> $config_host_mak
echo "NINJA=$ninja" >> $config_host_mak
diff --git a/tests/Makefile.include b/tests/Makefile.include
index dab1989a071..c9d1674bd07 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -111,7 +111,7 @@ quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \
$(TESTS_VENV_TOKEN): $(SRC_PATH)/pythondeps.toml
$(call quiet-venv-pip,install -e "$(SRC_PATH)/python/")
- $(PYTHON) python/scripts/mkvenv.py ensuregroup --online $< avocado
+ $(MKVENV_ENSUREGROUP) $< avocado
$(call quiet-command, touch $@)
$(TESTS_RESULTS_DIR):
--
2.43.0
next prev parent reply other threads:[~2023-11-24 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:23 [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2 Paolo Bonzini
2023-11-24 15:23 ` [PULL 01/10] coverity: physmem: use simple assertions instead of modelling Paolo Bonzini
2023-11-24 15:24 ` Paolo Bonzini [this message]
2023-11-24 15:24 ` [PULL 03/10] docs: document what configure does with virtual environments Paolo Bonzini
2023-11-24 15:24 ` [PULL 04/10] buildsys: Bump known good meson version to v1.2.3 Paolo Bonzini
2023-11-24 15:24 ` [PULL 05/10] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma) Paolo Bonzini
2023-11-24 15:24 ` [PULL 06/10] audio: Free consumed default audio devices Paolo Bonzini
2023-11-24 15:24 ` [PULL 07/10] disas/cris: Pass buffer size to format_dec() to avoid overflow warning Paolo Bonzini
2023-11-24 15:24 ` [PULL 08/10] system: Use &error_abort in memory_region_init_ram_[device_]ptr() Paolo Bonzini
2023-11-24 15:24 ` [PULL 09/10] configure: Make only once with pseudo-"in source tree" builds Paolo Bonzini
2023-11-24 15:24 ` [PULL 10/10] scripts: adjust url to Coverity tools Paolo Bonzini
2023-11-28 13:01 ` [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124152408.140936-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).